[
https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851253#action_12851253
]
Adrian Crum commented on OFBIZ-3623:
------------------------------------
Blas,
Thank you for all the work you did on this. There are a couple of items in your
patch that need attention:
1. In MacroFormRenderer.java, can we run the contents of autoCompleterTarget
through UtilHttp.encodeAmpersands to encode the ampersands?
2. In HtmlFormRenderer.java you check for:
"modelFormField.getWidgetStyle().length() > 0" - that check was done three
lines up. Your second check is not needed.
3. Could we give modelMenu.passConditionCount a better name? Like
displayedMenuItemCount? Or something similar? I know this seems trivial, but it
would make more sense to others looking at the code. I struggle with giving
methods meaningful names myself, so maybe others could help out here. We need
to name a method that takes all available menu items, and only returns the
count of the ones that pass a set of conditions.
> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <span id="${id}_indicator" style="display: none" class="indicator"><img
> /></span>
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> > </a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a
> attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and
> renderMenuClose methods need to know how many menu items pass the condition
> and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
