[
https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851803#action_12851803
]
Blas Rodriguez Somoza commented on OFBIZ-3621:
----------------------------------------------
Hi Bruno
Yes I do, editing css to change the logo height is not a good solution.
It should be possible to change the logo ans its size from the ui or replacing
the files without need to edit the css.
Removing the height from css, AFAIK there are two solutions to solve the error
in LI height:
1.- Increase background height. header_top_bg.gif height should be 4 pixel
greater than ofbiz_logo.gif.
2.- Decrease ul size with css (margin-bottom: - n px)
But solution 1 don't work for droppingcrumbs, so I use solution 2.
I tested using FF 3.5, IE 7, Opera 10 and Chrome. The errors are 4px Firefox,
2px IE and 0px (no error) in Opera and Chrome.
I also changed the background css from repeat-x to repeat, because this change
don't modify the default theme display and allow someone to use a background
with smaller height than the logo.
With the new patch (v4) , the logo and its size can be changed without editing
css, using the UI or replacing the logo file.
Is this a good solution for you ?
> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg,
> OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff,
> OFBIZ-3621_themes_xhtml_v4.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>"
> title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because
> the size of the background image means nothing for dimensioning, it will be
> clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the
> background. If the logo is only in the stylesheet without any trick, the logo
> will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear
> without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
