As Adrian and I previously discussed, he said he had discovered some possible problems with SequenceUtil in multi-threaded situations. He discovered this when he made EntityDataLoadContainer load each xml file in a thread.
I've recently done the same on my local copy, but I don't see any problems. What I did see, however, was that just throwing every xml data file into a thread(actually, a 4-count thread pool), had errors loading some files, because each file has an implicit dependency on some possible other set of files, and those files hadn't been loaded yet. So, before doing a thread load, the files would have to have an explicit dependency listed, so that correct ordering could be done. This is not something that would make ofbiz easier to use. Trying to figure out the implicit dependencies automatically by comparing each entity line isn't worthwhile, as that would be reimplementing a database, and what would be the point. So, Adrian, if you have any more pointers as to what your original change did, I'd appreciate any insight you might have. Otherwise, I will say that we can't load data in parallel. Additionally, I suspsected that SequenceUtil actually *didn't* have any problems. I wrote a test case quite a while back that did multi-threaded testing of SequenceUtil, and it never had any problems. It used 100 threads, with each thread trying to allocate 1000 sequence values.
