Is it reasonable for a non-commiter to review commits? To be honest, I never even considered that I should be doing that.
However, two other things occurred to me ... Got the distinct feeling that this points to a not very good practice when it comes to unit testers. I definitely understand the pain of attempting to force a "must have tester" policy but having a project code-coverage goal might be something to strive towards (with published metrics). Moreover, I would guess in this case a unit-tester would have likely caught the inverted condition check (if it was compiling). I am definitely not a fisheye expert, but I would hope with its JIRA integration that something could be automated that would drive reviews targeted at the commiters. Again having a code-review goal (published) would be something the project could strive towards. It would be pretty awesome to have Ofbiz - 2+ million lines of code, 100% code reviewed, 90% unit-test code coverage. -- View this message in context: http://n4.nabble.com/Re-svn-commit-r930737-ofbiz-trunk-framework-entity-src-org-ofbiz-entity-GenericDelegator-java-tp1752209p1752368.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
