[ 
https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857623#action_12857623
 ] 

Blas Rodriguez Somoza commented on OFBIZ-3653:
----------------------------------------------

I've added 4 new screenshots to show the effect of the patch. Those starting 
with OFBIZ-3653

As can be seen in the halign example, the previous small vertical misalignment 
between selects and text fields disappear.

The listform don't need comments, it is clear enough by itself.

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
>                 Key: OFBIZ-3653
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3653
>             Project: OFBiz
>          Issue Type: Bug
>          Components: themes
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Assignee: Bruno Busco
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3653_after2_halign.jpg, 
> OFBIZ-3653_after2_listform.jpg, OFBIZ-3653_before2_halign.jpg, 
> OFBIZ-3653_before2_listform.jpg, OFBIZ-3653_css.diff, pagination_select.JPG, 
> tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, 
> tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em 
> * 2 + 0.1em * 2) = 2.1 em 
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin 
> changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em; 
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling 
> correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the 
> proposed one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to