[ 
https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858243#action_12858243
 ] 

Adam Heath commented on OFBIZ-3708:
-----------------------------------

<div> and <span> are the same, just with different css.  display: inline solves 
most differents, maybe combined with a clear: both.  So no, do not change the 
field definitions to span, just because you can't align the divs correctly.

> Fields should be defined with span not div. (radio, date, lookup)
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3708
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3708
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CAL_after_bizznesstime.jpg, CAL_after_bluelight.jpg, 
> CAL_after_droppingcrumbs.jpg, CAL_after_flatgrey.jpg, CAL_after_tomahawk.jpg, 
> CAL_before_bizznesstime.jpg, CAL_before_bluelight.jpg, 
> CAL_before_droppingcrumbs.jpg, CAL_before_flatgrey.jpg, 
> CAL_before_tomahawk.jpg, LOOKUP_CAL_after_bizznesstime.jpg, 
> LOOKUP_CAL_before_bizznesstime.jpg
>
>
> Field markup should be a valid inline element.
> Defining fields with div (block) instead of span (inline) creates several 
> problems:
> - Missalignments in screen. (See LOOKUP_CAL screenshots)
> - Implies a end-of-line after the div.  (See CAL screenshots)
> - If used inside inline elements which should be OK, becames XHTML validation 
> errors. (Manufacturing -> MRP -> MRP log)
> Because this is a markup problem, it spans to all the themes.
> This patch contains 2 files in the framework/widget area and 5 in the themes 
> area.
> Because the source of the problem is in the framework/widget area, I opt to 
> assign the bug to the framework area.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to