Copying WorkEffortCostCalc as part of a ProductionRun
-----------------------------------------------------
Key: OFBIZ-3724
URL: https://issues.apache.org/jira/browse/OFBIZ-3724
Project: OFBiz
Issue Type: Improvement
Components: manufacturing
Affects Versions: SVN trunk
Reporter: Bob Morley
Fix For: SVN trunk
Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch
Currently when a ProductionRun is created the WorkEffortCostCalc relations are
not cloned from the routing tasks. This results in not being able to change
the CostCalc as part of a ProductionRun unless you were to change the routing
task template for all production runs. As part of reviewing this patch I would
like two things to be considered --
I created this patch which includes an enhancement to the production run unit
tests to test for the creation of these newly cloned relationships.
1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this
does not feel right -- it caused me to add that permission into the sample
user/security group to execute the services. I wonder if these services should
be in the WorkEffort component with appropriate work effort permission.
2) migration concerns -- if people have existing production runs in place, the
new createProductionRunTaskCosts will not pickup the cost calcs that were not
copied. Rather than put "backwards compatible" code in, I would prefer (if we
want to handle this) to create a service that performs this clone on
non-completed/closed production runs that is executed as part of a migration.
Would like community discussion on this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
