Adrian Crum wrote: > Robert Morley wrote: >> On Apr 17, 2010, at 6:18 PM, Adam Heath wrote: >> >>> I've got it working locally, for base. Will be applying it to the >>> other components that have test classes. Currently, it'll only save >>> about 145k of compressed bytecode data(based on the size of the jars). >>> But that will probably increase as more source-level tests are added. >>> >>> We might always want to consider splitting ofbiz-component.xml, >>> splitting screen/form/script resources, basically move out everything >>> that is only used when tests are being run, and don't make it >>> available at all during normal runs. >>> >> >> Did we get closure on separating out the test and product artifacts in >> the src folder? It seems to me that separation would be a good thing >> as you have alluded to in your last paragraph. As for concerns with >> build dependencies, I would have thought that it would be standard >> practice for any (reasonable sized) change to go through a series of >> "clean-all", "run-install", "run-tests" before doing the commit. >> Certainly as the bulk of unit tests increase, it will have to be >> become standard practice to avoid failing builds. > > As far as I can tell, there is still some disagreement on how it should > be done. Adam committed some stuff over the weekend - which I haven't > looked at yet.
For every component that had classes in some test folder, there is now a foo-test.jar in build/lib. The existing ofbiz-component.xml classpath entries will still end up reading both jars, because it has a wildcard that fetches all jars in that folder. It'd be nice if the startup system would only load foo-test.jar when running tests, but that would take a bit more effort. At the very least, its now possible to create a full system deployment, using zip/deb/whatever, that doesn't even include the files that are only useful for testing purposes. ps: except that it's not, because at the very least entityengine.xml includes test database definitions. And ofbiz-component.xml also includes those test definitions.
