Hi Hans,

Wouldn't it be better to have a CustRequestStatus.reason field for this?  Using 
CustRequest.reason doesn't seem right for this situation.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 28/04/2010, at 8:36 PM, [email protected] wrote:

> Author: hansbak
> Date: Wed Apr 28 08:36:05 2010
> New Revision: 938817
> 
> URL: http://svn.apache.org/viewvc?rev=938817&view=rev
> Log:
> allow an optional 'reason' parameter when the status is changed of a customer 
> request
> 
> Modified:
>    
> ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml
>    ofbiz/trunk/applications/order/servicedef/services_request.xml
> 
> Modified: 
> ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml?rev=938817&r1=938816&r2=938817&view=diff
> ==============================================================================
> --- 
> ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml
>  (original)
> +++ 
> ofbiz/trunk/applications/order/script/org/ofbiz/order/request/CustRequestServices.xml
>  Wed Apr 28 08:36:05 2010
> @@ -469,6 +469,9 @@ under the License.
>         <check-errors/>
> 
>         <set field="custRequest.statusId" from-field="parameters.statusId"/>
> +        <if-not-empty field="parameters.reason"><!-- update reason if 
> provided -->
> +            <set field="custRequest.reason" from-field="parameters.reason"/>
> +        </if-not-empty>
>         <store-value value-field="custRequest"/>
>         <call-simple-method method-name="createCustRequestStatus"/>
>     </simple-method>
> 
> Modified: ofbiz/trunk/applications/order/servicedef/services_request.xml
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services_request.xml?rev=938817&r1=938816&r2=938817&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/servicedef/services_request.xml (original)
> +++ ofbiz/trunk/applications/order/servicedef/services_request.xml Wed Apr 28 
> 08:36:05 2010
> @@ -174,6 +174,7 @@ under the License.
>         <description>Set the Customer Request  Status</description>
>         <attribute name="custRequestId" type="String" mode="INOUT" 
> optional="false"/>
>         <attribute name="statusId" type="String" mode="IN" optional="false"/>
> +        <attribute name="reason" type="String" mode="IN" optional="true" 
> allow-html="safe"/>
>         <attribute name="oldStatusId" type="String" mode="OUT" 
> optional="true"/>
>         <attribute name="fromPartyId" type="String" mode="OUT" 
> optional="true"/><!-- for notification services -->
>         <attribute name="custRequestName" type="String" mode="OUT" 
> optional="true"/><!-- for notification services -->
> 
> 

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to