--- On Tue, 5/4/10, Scott Gray <[email protected]> wrote: > At some point for sure. > > The real and big problem with the content component is that > it's almost impossible to figure out what the hell half the > methods do. They're poorly written, poorly documented > and in a lot of cases isn't doing things correctly > anyway. How do you write backwards compatible code for > something thats undecipherable?
Don't worry about backwards compatibility - there is very little chance anyone is using it - since it is so broken. > I would say about 80-90% of the content code fits into the > above description and IMO should just be ripped out and a > fresh start made. That's why I wrote my own forum application. I kept the data structure, but modified how the data is stored. Then I wrote all of my own screens - the existing ones are confusing and often don't work. -Adrian > On 5/05/2010, at 5:13 PM, Anil Patel wrote: > > > Makes sense > > +1 > > > > Thanks and Regards > > Anil Patel > > HotWax Media Inc > > Find us on the web at www.hotwaxmedia.com or Google > Keyword "ofbiz" > > > > On May 5, 2010, at 1:10 AM, Adrian Crum wrote: > > > >> Time to look at a JackRabbit integration? > >> > >> ;-) > >> > >> -Adrian > >> > >> --- On Tue, 5/4/10, [email protected] > <[email protected]> > wrote: > >> > >>> From: [email protected] > <[email protected]> > >>> Subject: svn commit: r941139 - > /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/MenuWrapTransform.java > >>> To: [email protected] > >>> Date: Tuesday, May 4, 2010, 7:25 PM > >>> Author: lektran > >>> Date: Wed May 5 02:25:26 2010 > >>> New Revision: 941139 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=941139&view=rev > >>> Log: > >>> Put the null check a little higher so that it > actually does > >>> the check before an NPE can occur. Giving up > on this > >>> transform, I hate the content component. > >>> > >>> Modified: > >>> > >>> > ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/MenuWrapTransform.java > >>> > >>> Modified: > >>> > ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/MenuWrapTransform.java > >>> URL: > >>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/MenuWrapTransform.java?rev=941139&r1=941138&r2=941139&view=diff > >>> > ============================================================================== > >>> --- > >>> > ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/MenuWrapTransform.java > >>> (original) > >>> +++ > >>> > ofbiz/trunk/framework/widget/src/org/ofbiz/widget/menu/MenuWrapTransform.java > >>> Wed May 5 02:25:26 2010 > >>> @@ -182,13 +182,15 @@ public class > MenuWrapTransform > >>> implement > >>> > >>> String menuName = > >>> (String)templateCtx.get("menuName"); > >>> > >>> String menuWrapperClassName > = > >>> > (String)templateCtx.get("menuWrapperClassName"); > >>> > >>> HtmlMenuWrapper menuWrapper > = > >>> HtmlMenuWrapper.getMenuWrapper(request, > response, session, > >>> menuDefFile, menuName, menuWrapperClassName); > >>> - > > >>> String associatedContentId = > >>> > (String)templateCtx.get("associatedContentId"); > >>> - > > >>> > menuWrapper.putInContext("defaultAssociatedContentId", > >>> associatedContentId); > >>> - > > >>> menuWrapper.putInContext("currentValue", > view); > >>> > >>> > >>> if (menuWrapper == null) { > >>> > >>> throw new > >>> IOException("HtmlMenuWrapper with def file:" + > menuDefFile + > >>> " menuName:" + menuName + " and > HtmlMenuWrapper class:" + > >>> menuWrapperClassName + " could not be > instantiated."); > >>> > >>> } > >>> + > >>> + > > >>> String associatedContentId = > >>> > (String)templateCtx.get("associatedContentId"); > >>> + > > >>> > menuWrapper.putInContext("defaultAssociatedContentId", > >>> associatedContentId); > >>> + > > >>> menuWrapper.putInContext("currentValue", > view); > >>> + > >>> > >>> String menuStr = > >>> menuWrapper.renderMenuString(); > >>> > >>> out.write(menuStr); > >>> > } > >>> > >>> > >>> > >> > >> > >> > > > >
