[ 
https://issues.apache.org/jira/browse/OFBIZ-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864307#action_12864307
 ] 

chris snow commented on OFBIZ-3749:
-----------------------------------

Hi Erwan,

Sorry to be a pain, but the change with the Debug.infoOn() check is broken, it 
should be:

{code}
// return an empty field help description if there is no value found for the key
if (fieldDescription.equals(messageId)) {
    if (Debug.infoOn()) {
        Debug.logInfo("No help text found in [" + entityResourceName + "] with 
key [" + messageId + "]", module);
    }
    return "";
}
{code}

I.e. we need to return an empty string if there is no value found for the key, 
regardless of whether debuging is on or off.

Cheers,

Chris

> Field description tooltips show key if help text is not found
> -------------------------------------------------------------
>
>                 Key: OFBIZ-3749
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3749
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Erwan de FERRIERES
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: UtilHelpText.patch
>
>
> Tooltip currently shows field help message key if no help text has been 
> provided.  For details, see:
> http://ofbiz.135035.n4.nabble.com/New-branch-is-now-available-for-upcoming-releases-of-10-04-series-tp2111929p2122465.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to