What is the real benefit of this decorator screen when we have a similar decorator CommonCommunicationEventDecorator present in the same file?

The difference b/w these two decorators is just negligible.

The CommonMyCommunicationEventDecorator screen does not have a headerItem and a permission check in the "pre-body" section but CommonCommunicationEventDecorator screen does have it.

Moreover I do not think it is correct approach to append some funny parameter (My) in the URL to determine which decorator to be used.

Regards
Vikas

On May 13, 2010, at 10:36 AM, [email protected] wrote:

Author: hansbak
Date: Thu May 13 05:06:06 2010
New Revision: 943802

URL: http://svn.apache.org/viewvc?rev=943802&view=rev
Log:
fixed email send error reported in issue: 3465

Modified:
   ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml

Modified: ofbiz/trunk/applications/party/widget/partymgr/ CommonScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml?rev=943802&r1=943801&r2=943802&view=diff
= = = = = = = = ====================================================================== --- ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml (original) +++ ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml Thu May 13 05:06:06 2010
@@ -202,6 +202,34 @@ under the License.
            </widgets>
        </section>
    </screen>
+    <screen name="CommonMyCommunicationEventDecorator">
+        <section>
+            <actions>
+ <script location="component://party/webapp/partymgr/ WEB-INF/actions/communication/GetMyCommunicationEventRole.groovy"/>
+            </actions>
+            <widgets>
+ <decorator-screen name="main-decorator" location="$ {parameters.mainDecoratorLocation}">
+                    <decorator-section name="pre-body">
+ <include-menu location="component:// party/widget/partymgr/PartyMenus.xml" name="CommEventTabBar"/> + <include-menu location="component:// party/widget/partymgr/PartyMenus.xml" name="CommSubTabBar"/>
+                    </decorator-section>
+                    <decorator-section name="body">
+                        <section>
+                            <condition>
+ <if-has-permission action="_VIEW" permission="PARTYMGR"/>
+                            </condition>
+                            <widgets>
+ <decorator-section-include name="body"/>
+                            </widgets>
+                            <fail-widgets>
+ <label style="h3">$ {uiLabelMap.PartyMgrViewPermissionError}</label>
+                            </fail-widgets>
+                        </section>
+                    </decorator-section>
+                </decorator-screen>
+            </widgets>
+        </section>
+    </screen>
    <screen name="CommonRequestDecorator">
        <section>
            <actions/>



Reply via email to