[
https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876020#action_12876020
]
Scott Gray commented on OFBIZ-3373:
-----------------------------------
A few points:
- I'm little vague on how immutability works but keep in mind that the model is
modified during construction only.
- I wrote this patch before that discussion was had.
- I actually couldn't care less about how the functionality is implemented, it
is the functionality itself that is important to me.
- This patch is just a draft of the functionality that I envisaged, people are
free to do with it as they please. The only thing I ask is that any changes to
the actual plug-in behavior be discussed thoroughly.
- If the base model is never actually used because the factory always returns
the injected version then to be honest I don't see what benefits are gained by
not touching it directly.
> Adding menu merging feature
> ---------------------------
>
> Key: OFBIZ-3373
> URL: https://issues.apache.org/jira/browse/OFBIZ-3373
> Project: OFBiz
> Issue Type: Wish
> Components: framework
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: googlebase-inject.patch, injections.patch, links.jpg,
> partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought
> to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in
> order to have an high level of code reuse and great consistency all over
> OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in
> the framework core or in a lower level module) that should be somewhat
> changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of
> this feature:
> in the party module there are lot of links that co to order application,
> account etc. Those menu link could be used defining a simple menu (say it
> partylinks_menu) in the party application that contains only party or
> framework related links (i.e. profile); additional components like order or
> accounting could define more menus that merges-to the partylinks_manu so that
> when the menu is rendered IN THE PARTY APPLICATION the new menu items added
> in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help
> us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines
> such mergin menus and the menu rendered should lookup the entity to check if
> one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
