[
https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876569#action_12876569
]
Sascha Rodekamp commented on OFBIZ-3786:
----------------------------------------
Hi Jacques i'll try to explain what's in my mind
controller.xml specialpurpose/ecommerce
{code:xml}
<!-- Events run from here for the first hit in a visit -->
<firstvisit>
<event name="autoLoginCheck" type="java"
path="org.ofbiz.webapp.control.LoginWorker" invoke="autoLoginCheck"/>
<event name="checkTrackingCodeCookies" type="java"
path="org.ofbiz.marketing.tracking.TrackingCodeEvents"
invoke="checkTrackingCodeCookies"/>
<event name="setDefaultStoreSettings" type="java"
path="org.ofbiz.product.product.ProductEvents"
invoke="setDefaultStoreSettings"/>
</firstvisit>
{code}
The Code in firstVisit is never used, because of the wrong if-statement in the
RequestHandler.
{code}
if (this.trackVisit(request) && session.getAttribute("visit") == null) {
...
}
{code}
session.getAttribute("visit") is never null. It is set in the ControlServlet
before. (VisitHandler.getVisitId(session); )
> First Visit is never been called
> --------------------------------
>
> Key: OFBIZ-3786
> URL: https://issues.apache.org/jira/browse/OFBIZ-3786
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3786_RequestHandler.java.patch
>
>
> I noticed that the first visist element in a controller.xml is never been
> called.
> Here is a proposal patch to solve this issue.
> Now everytime when a session is created, the first visit element will be
> called.
> I don't now if this is the best solution, but maybe we can discuss
> So long
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
