On 3/08/2010, at 5:16 AM, Adam Heath wrote: > On 08/01/2010 03:52 AM, [email protected] wrote: >> Author: lektran >> Date: Sun Aug 1 08:52:19 2010 >> New Revision: 981179 >> >> URL: http://svn.apache.org/viewvc?rev=981179&view=rev >> Log: >> Deprecate method that doesn't use its input parameter and add a new method >> that doesn't take one. > > What is the method name, at the very least. The commit message needs to > kinda stand on it's own.
Fair call, I've added extra info to the commit message. Thanks Scott > >> >> Modified: >> >> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java >> >> Modified: >> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java?rev=981179&r1=981178&r2=981179&view=diff >> ============================================================================== >> --- >> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java >> (original) >> +++ >> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java >> Sun Aug 1 08:52:19 2010 >> @@ -1133,7 +1133,7 @@ public class CheckOutHelper { >> } >> } >> >> - public Map<String, Object> checkOrderBlacklist(GenericValue userLogin) >> { >> + public Map<String, Object> checkOrderBlackList() { >> if (cart == null) { >> return ServiceUtil.returnSuccess("success"); >> } >> @@ -1201,6 +1201,11 @@ public class CheckOutHelper { >> } >> } >> >> + @Deprecated >> + public Map<String, Object> checkOrderBlacklist(GenericValue userLogin) >> { >> + return checkOrderBlackList(); >> + } >> + >> public Map<String, Object> failedBlacklistCheck(GenericValue >> userLogin, GenericValue productStore) { >> Map<String, Object> result; >> String errMsg=null; >> >> >
smime.p7s
Description: S/MIME cryptographic signature
