On 08/05/2010 10:09 AM, Jacques Le Roux wrote:
Yes, I agree, it  isn't worth the work. BTW, there are other cases also.

If there hasn't been an official release, or, at the least, a release branch, that contains a typo such as this, then just go ahead and change it.


Jacques

From: "Adrian Crum" <[email protected]>
From my perspective, the misspelled type ID is not a big issue. I
wouldn't change it.

-Adrian

On 8/5/2010 6:05 AM, [email protected] wrote:
Author: jacopoc
Date: Thu Aug 5 13:05:19 2010
New Revision: 982596

URL: http://svn.apache.org/viewvc?rev=982596&view=rev
Log:
Fix for typo; unfortunately the typo is also in the id that is a
primary key: this should be fixed as well but will require some
work to make it backward compatible and I don't have time to do it now.


Modified:
ofbiz/trunk/applications/product/data/ProductTypeData.xml

Modified: ofbiz/trunk/applications/product/data/ProductTypeData.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/data/ProductTypeData.xml?rev=982596&r1=982595&r2=982596&view=diff

==============================================================================

--- ofbiz/trunk/applications/product/data/ProductTypeData.xml (original)
+++ ofbiz/trunk/applications/product/data/ProductTypeData.xml Thu Aug
5 13:05:19 2010
@@ -179,7 +179,7 @@ under the License.
<ProductAssocType description="Also Bought" hasTable="N"
parentTypeId="" productAssocTypeId="ALSO_BOUGHT"/>
<ProductAssocType description="Upgrade or Up-Sell" hasTable="N"
parentTypeId="" productAssocTypeId="PRODUCT_UPGRADE"/>
<ProductAssocType description="Complementary or Cross-Sell"
hasTable="N" parentTypeId=""
productAssocTypeId="PRODUCT_COMPLEMENT"/>
-<ProductAssocType description="Incompatable" hasTable="N"
parentTypeId="" productAssocTypeId="PRODUCT_INCOMPATABLE"/>
+<ProductAssocType description="Incompatible" hasTable="N"
parentTypeId="" productAssocTypeId="PRODUCT_INCOMPATABLE"/>
<ProductAssocType description="New Version, Replacement" hasTable="N"
parentTypeId=""
productAssocTypeId="PRODUCT_OBSOLESCENCE"/>
<ProductAssocType description="Actual Product Component" hasTable="N"
parentTypeId=""
productAssocTypeId="PRODUCT_COMPONENT"/>
<ProductAssocType description="Equivalent or Substitute" hasTable="N"
parentTypeId=""
productAssocTypeId="PRODUCT_SUBSTITUTE"/>







Reply via email to