[ 
https://issues.apache.org/jira/browse/OFBIZ-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904962#action_12904962
 ] 

Liu Xiangqian edited comment on OFBIZ-3916 at 9/1/10 3:41 AM:
--------------------------------------------------------------

This patch changes the code from orgianal version shown in the case description 
to the follow so the exception will only be thrown when any exception occurs.

 public static void writeObject(StringBuilder sb, Object value, boolean 
allowJsonResolve) throws IOException {
        try {
            StringWriter writer = new StringWriter();
            if (encodeObject(writer, value, allowJsonResolve)) {
                sb.append(writer.toString());
                return;
            }
        } catch (Exception e) {
            throw new IOException("Can't write (" + value + ")");            
        }
    }

      was (Author: redcamper):
    This patch changes the code from orgianal version shown in the case 
description to the follow 

 public static void writeObject(StringBuilder sb, Object value, boolean 
allowJsonResolve) throws IOException {
        try {
            StringWriter writer = new StringWriter();
            if (encodeObject(writer, value, allowJsonResolve)) {
                sb.append(writer.toString());
                return;
            }
        } catch (Exception e) {
            throw new IOException("Can't write (" + value + ")");            
        }
    }
  
> method writeObject(StringBuilder sb, Object value, boolean allowJsonResolve) 
> in UtilIO always throw an IOException
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3916
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3916
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>         Environment: Server side: Mac OSX 10.6.4
> Client: Safari 5.0.1
>            Reporter: Liu Xiangqian
>         Attachments: OFBIZ-3916.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Tried to invoke method UtilIO.writeObject(StringBuilder sb, Object value, 
> boolean allowJsonResolve) but found the follow code
>    try {
>             StringWriter writer = new StringWriter();
>             if (encodeObject(writer, value, allowJsonResolve)) {
>                 sb.append(writer.toString());
>                 return;
>             }
>         } catch (Exception e) {
>         }
>         throw new IOException("Can't write (" + value + ")");
> These codes casued the method always throw an IOException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to