Hi Erwan, I am not saying it harms. I do not see any utility in having a portlet using the uiLabelDecorator instead of directly including the resource it needs.
-Bruno 2010/9/13 Erwan de FERRIERES <[email protected]> > Le 11/09/2010 09:34, Bruno Busco a écrit : > >> Hi Erwan, >> >> I am looking into the PortalPortlet system and in the MyPortal >> application. >> What I am trying to do is to have a complete independence of MyPortal from >> applications. >> Doing this I have faced this uiLabelDecorator that has been created in >> several applications. >> I think we should eliminate this pattern and have each portlet include its >> own resource files. But before stepping over with this change I would like >> to hear if this is a problem for anybody. >> I think this pattern complicates the things and generate portlets grouping >> that are not needed. Generally a portlet is a single screen unit that >> should >> be independent as much as possible. >> >> I have seen also that a showPortletUiLabelDecorator has been added. Are we >> sure we need this? >> > > Hi Bruno, > > this uiLabelDecorator should be seen as a common screen for portlet pages. > It is just loading common uilabels, so this should do no harm to the portlet > itself. Moreover, each portlet can still include its label resources. > > Myportal is just a showcase of the portal use in OFBiz, and this > uiLabelDecorator takes just all the properties from the main-decorator, so a > generic decorator, targeted only to displaying information is created. > > HTH > > > -- > Erwan de FERRIERES > www.nereide.biz >
