[
https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917946#action_12917946
]
Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------
Sascha,
I reviewed Ankit's patch yesterday evening but did not committed it yet. Here
are my comments so far
I simply
* replaced .length > 0 by .length the > 0 part is not needed
* used if (jQuery('#initializedCompletedCartDiscount').length &&
jQuery('#initializedCompletedCartDiscount').val() == 0) { instead of
if (jQuery('#initializedCompletedCartDiscount') !=undefined &&
jQuery('#initializedCompletedCartDiscount').val() == 0) { which is not correct
* I noticed harcoded "Attn: " and "Expires:" but gave up to change them,
perhaps someone will clear them one day...
I hope I did not forget anything because I did not take the time to test, I
only reviewed and it looked fine to me. I wonder though if we could not have
refactored this file, some snippets seem redundant...
> Ecommerce Migration
> -------------------
>
> Key: OFBIZ-3978
> URL: https://issues.apache.org/jira/browse/OFBIZ-3978
> Project: OFBiz
> Issue Type: Sub-task
> Components: specialpurpose/ecommerce
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Attachments: CheckoutProcess.patch, CheckoutProcess.patch,
> OFBIZ-3978_ecommerceMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
