[
https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923363#action_12923363
]
Jacques Le Roux commented on OFBIZ-3995:
----------------------------------------
Hi Sascha,
Looks like we did not do a good job here. I must take my part and should have
taken testUpdatePartyTelecomNumber more seriously. The 2 1st tests in
updateContactMech were wrong but it was our error to not check further after
testUpdatePartyTelecomNumber popped up, lesson learned.
I thought about opening an issue about the note David left in r1025838 comment
{quote}
this fixes that bug for now, and if this really should be a constraint the
higher level services need to be changed to do something else, ie to not call
the updateContactMech/etc services
{quote}
But I think it's really old (wrong) code that have been neglicted until you
stumbled upon. We could even remove the whole commented block. But I guess
David prefered to keep it in case it would help someone with an old version to
understand the change.
> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
> Key: OFBIZ-3995
> URL: https://issues.apache.org/jira/browse/OFBIZ-3995
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3995_ContactMechServices.patch,
> OFBIZ-3995_ContactMechServices_JunitTestsFix.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop).
> The result message was Contact Mechanism Successfully Updated. The service
> (updateContactMech) tries to differ between email, phone, web ... address
> changes.
> But the conditions are always false , because he can't read the from the
> parameter fields. This patch make the service read the parameters in the
> right way.
> Have a good day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
