Buildbot lies. Everything compiles fine. -Adrian
--- On Fri, 12/31/10, Jacques Le Roux <[email protected]> wrote: > Mmm, yes maybe... but we have more > than 100 such cases... So I wonder if it's such a problem (I > did not thought much about it yet) > BTW did you see the builbot report for r1054161? > > Jacques > > From: "Adrian Crum" <[email protected]> > > <set field="parameters.presentation" > value="window"/> > > > > in common/widget/LookupScreens. It's not a bug or > major issue, it's just bad programming style. > > > > -Adrian > > > > --- On Fri, 12/31/10, Jacques Le Roux <[email protected]> > wrote: > > > >> From: Jacques Le Roux <[email protected]> > >> Subject: Re: Revision 935578 > >> To: [email protected] > >> Date: Friday, December 31, 2010, 1:27 AM > >> It's not clear to me where this could > >> be > >> > >> Jacques > >> > >> From: "Adrian Crum" <[email protected]> > >> > Revision 935578 has screen widget code > writing values > >> to the parameters Map. Why was that necessary? The > value > >> being passed from widget to widget could be a > regular screen > >> context field. > >> > > (btw, I apologize for not replying to > the commit > >> messages - I don't have access to them on this > computer.) > >> > > -Adrian > >> > >> > >> > > > > > > > >
