[
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979870#action_12979870
]
Ryan Foster commented on OFBIZ-4092:
------------------------------------
duh, I guess I should have actually read your patch first before I started
thinking out loud. Your solution looks great. I made couple of small tweaks
to it to remove some markup that I thought wasn't really necessary. For
instance, we don't really need to enclose each app title in in a <p> tag since
the <a> is already set to display block. I also put a set height to the <li>
tag and removed the empty <p> tags with spaces from the last <li>. Please
don't take this personally, but one of my biggest pet peeves is using spaces
and breaks in markup to control layout. Let's try to avoid that as much as
possible.
I have incorporated the changes from your last patch and made a few more design
changes as well in my latest patch.
1. added additional styling to the main navigation to highlight the select app
a bit more.
2. expanded on your change to the selected app navigation link to give it even
more distinction
3. enhanced the styling of the tab-bar area.
4. added some misc. CSS3 styling enhancements to main nav and app nav areas
for browsers that support text-shadow.
> Update The Flat Grey Visual Theme
> ---------------------------------
>
> Key: OFBIZ-4092
> URL: https://issues.apache.org/jira/browse/OFBIZ-4092
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: accounting800x600.png, catalog800x600.png,
> catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
> flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
> ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
> timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments,
> but the theme can't depend on it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
