We need the smallSubmit style so we can style links to look like submit
buttons. Maybe we could change the CSS class to "a.smallSubmit" to make
sure it is used only for <a> elements.
The button-style-1 and button-style-2 style names are pretty generic -
they don't indicate how the button should appear (aside from the obvious
- that they should look like buttons). Originally, the rows of buttons
below the page title had two styles that indicated two types of buttons:
those that linked to other pages within the application (intra-app) and
others that linked to pages outside the application (inter-app). That
distinction has been lost in recent changes.
A similar thing was done with the table header styles - there are two
styles to choose from, depending on how you use them. The style names
don't indicate what they look like.
I don't think there is anything wrong with having more than one style to
choose from. If we were to cut back too much on the selection, then the
UI would start to look bland or monotonous.
I created a Wiki page that listed some of the deprecated styles and
another page that describes the new styles and how they should be used.
Those pages are effective only when people take the time to read them.
-Adrian
On 1/12/2011 12:01 PM, Bruno Busco wrote:
In addition, when deprecating or selecting styles to be used we should
better use style names that describe what the button IS in the screen and
not HOW it should appear.
So style names like
.buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
.button-style-1, .button-style-2,
should not be used.
Style names like:
.buttontext,
.loginButton,
.button,
input[type="reset"],
input[type="submit"],
input[type="button"]
are OK.
In this way the theme can make a button larger or smaller than another
button according to its function.
My two cents.
-Bruno
2011/1/12 Ryan Foster (JIRA)<[email protected]>
[
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883]
Ryan Foster commented on OFBIZ-4092:
------------------------------------
I tried deleting deprecated styles and letting things break when I created
the BizznessTime theme... mostly just pissed people off. :)
Update The Flat Grey Visual Theme
---------------------------------
Key: OFBIZ-4092
URL: https://issues.apache.org/jira/browse/OFBIZ-4092
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
Attachments: ac_flatgrey.patch, ac_images.zip,
accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
timeSheet.png
Update the Flat Grey visual theme. Design objectives:
1. Floating, flexible layout - screen can be resized.
2. Sight impaired accessible - users can change font size in their
browser.
3. Supports RTL layout.
4. Does not require JavaScript. JavaScript can be used to add
embellishments, but the theme can't depend on it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
