[
https://issues.apache.org/jira/browse/OFBIZ-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-4114.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 10.04
Release Branch 09.04
Assignee: Jacques Le Roux
Thanks for report Paul,
I have not applied your patch but made the following changes.
# PosTransaction.java (in trunk at r1060261, R10.04 at r1060375, R9.04 at r
1060378.
** As it's not a service but a public method we should not use return
ServiceUtil.returnError here but return null
# InvoiceServices.java (in trunk at r1060368, R10.04 at r1060383, R9.04 at
r1060385
** For calcHeaderAdj as it's not a service but a private method we should not
use return ServiceUtil.returnError here but BigDecimal.ZERO
** Same for createInvoiceTerms but not return as it returns void
** Fix all other cases by adding return as you suggested
> ServiceUtil.returnError called but its result not returned
> ----------------------------------------------------------
>
> Key: OFBIZ-4114
> URL: https://issues.apache.org/jira/browse/OFBIZ-4114
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: rev 1058379
> Reporter: Paul Foxworthy
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk
>
> Attachments:
> OFBIZ-4114_InvoiceServices_returnError_result_not_returned.patch,
> OFBIZ-4114_PosTransaction_returnError_result_not_returned.patch
>
>
> In
> applications/accounting/src/org/ofbiz/accounting/Invoice/InvoiceServices.java,
> there are numerous calls to ServiceUtil.returnError where nothing is done
> with the result of the call. Surely a
> return ServiceUtil.returnError
> was intended?
> A grep turned up one other place with a similar problem, PosTransaction.java .
> Patches attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
