[jira] Commented: (OFBIZ-4106) deleteCustomerTaxAuthInfo page called from /ecommerce/control/viewprofile

[Jacques Le Roux (JIRA)]

    [ 
https://issues.apache.org/jira/browse/OFBIZ-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983817#action_12983817
 ] 

Jacques Le Roux commented on OFBIZ-4106:
----------------------------------------

Hi Michał,

This is not an easy fix, because, for secruoty reason, we would need to have a 
form into a form and that does not work in HTML. This because the faulty 
snippet is rendered by "screens.render" in 
specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl
{code}
<form method="post" action="<@ofbizUrl>createCustomerTaxAuthInfo</@ofbizUrl>" 
name="createCustTaxAuthInfoForm">
    <input type="hidden" name="partyId" value="${party.partyId}"/>
    
${screens.render("component://order/widget/ordermgr/OrderEntryOrderScreens.xml#customertaxinfo")}
    <input type="submit" value="${uiLabelMap.CommonAdd}" class="smallSubmit"/>
</form>
{code}

So we would have this patch

{code}
### Eclipse Workspace Patch 1.0
#P release09.04
Index: applications/order/webapp/ordermgr/entry/customertaxinfo.ftl
===================================================================
--- applications/order/webapp/ordermgr/entry/customertaxinfo.ftl        
(revision 1060759)
+++ applications/order/webapp/ordermgr/entry/customertaxinfo.ftl        
(working copy)
@@ -19,7 +19,13 @@
 <#if partyTaxAuthInfoAndDetailList?exists>
     <#list partyTaxAuthInfoAndDetailList as partyTaxAuthInfoAndDetail>
         <div>
-            <a 
href="<@ofbizUrl>deleteCustomerTaxAuthInfo?partyId=${partyId}&amp;taxAuthPartyId=${partyTaxAuthInfoAndDetail.taxAuthPartyId}&amp;taxAuthGeoId=${partyTaxAuthInfoAndDetail.taxAuthGeoId}&amp;fromDate=${partyTaxAuthInfoAndDetail.fromDate}</@ofbizUrl>"
 class="buttontext">X</a>
+          <form name="deleteCustomerTaxAuthInfo" 
id="deleteCustomerTaxAuthInfo" method="POST" 
action="<@ofbizUrl>deleteCustomerTaxAuthInfo</@ofbizUrl>">
+            <input type="hidden" name="partyId" value="${partyId}">
+            <input type="hidden" name="taxAuthPartyId" 
value="${partyTaxAuthInfoAndDetail.taxAuthPartyId}">
+            <input type="hidden" name="taxAuthGeoId" 
value="${partyTaxAuthInfoAndDetail.taxAuthGeoId}">
+            <input type="hidden" name="fromDate" 
value="${partyTaxAuthInfoAndDetail.fromDate}">
+            <input type="submit" name="deleteCustomerTaxAuthInfo" 
class="buttontext" value="X">
+          </form>
             [${partyTaxAuthInfoAndDetail.geoCode}] 
${partyTaxAuthInfoAndDetail.geoName} 
(${partyTaxAuthInfoAndDetail.groupName?if_exists}): ${uiLabelMap.PartyTaxId} 
[${partyTaxAuthInfoAndDetail.partyTaxId?default("N/A")}], 
${uiLabelMap.PartyTaxIsExempt} 
[${partyTaxAuthInfoAndDetail.isExempt?default("N")}]
         </div>
     </#list>
{code}

And it would generate the form deleteCustomerTaxAuthInfo into the form 
createCustTaxAuthInfoForm and that can't work. So it needs to be replaced by 
calls from the calling screen. Can you handle the case and provide a patch?

Thanks for your interest in OFBiz

> deleteCustomerTaxAuthInfo page called from /ecommerce/control/viewprofile
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-4106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4106
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 09.04
>         Environment: Linux x64 Debian AMD64
>            Reporter: Michał Cukierman
>         Attachments: Zaznaczenie_001.png
>
>
> Steps to reproduce:
> 1) Login to ecommerce app
> 2) View the profile
> 3) Add some  entries uder Tax Identification and Exemption
> 4) Try to delete previously added value

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.