Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

[Adrian Crum]

Thanks Jacques! That is a good compromise.

-Adrian

On 1/30/2011 2:51 AM, Jacques Le Roux wrote:

Adrian,

Inline

From: "Adrian Crum" <adrian.c...@sandglass-software.com>

Using the same logic, the page title should say "Layout Demo (page-title)" because it is rendered in the same way as <h1>.

The whole point of the screen is to look at the markup - to understand how a screen's markup is composed and how various styles are applied. In other words, if you want to use the Layout Demo screen as a tool, then looking at the markup is required - not optional.

Then this should be said on the page, the more we help the better.

I have committed a change for this at r1065246+1065247 (in Italian should be checked)

Thanks

Jacques

-Adrian

On 1/29/2011 12:53 PM, Bruno Busco wrote:

Adrian,

I thougth this was usefull above all when different styles are rendered in

the same way (i.e. h4, h5, h6).

In this case, having different texts, helps understanding very easily even

if not looking at the markup.

-Bruno
2011/1/29 Adrian Crum<adrian.c...@sandglass-software.com>

Bruno,

At first glance, it might seem logical to have text describing each of the styles or elements being displayed, but it really isn't necessary - since

the styles/elements can be seen when viewing the markup.

-Adrian


On 1/29/2011 6:22 AM, bus...@apache.org wrote:

Author: buscob
Date: Sat Jan 29 14:22:28 2011
New Revision: 1065018

URL: http://svn.apache.org/viewvc?rev=1065018&view=rev
Log:
Added other button styles in the Layout demo.
Added Italian localization.

Modified:
     ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
     ofbiz/trunk/framework/webtools/widget/MiscScreens.xml

Modified: ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml
URL:

http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1065018&r1=1065017&r2=1065018&view=diff

============================================================================== --- ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml (original) +++ ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml Sat Jan 29

14:22:28 2011
@@ -2444,9 +2444,11 @@
</property>
<property key="WebtoolsLayoutDemo">
<value xml:lang="en">Layout Demo</value>
+<value xml:lang="it">Dimostrazione Layout</value>
</property>
<property key="WebtoolsLayoutDemoText">
<value xml:lang="en">Demonstrate layout best practices and
provide a visual theme test page.</value>

+<value xml:lang="it">Dimostrazione di come utilizzare gli stili e pagina

per il test dei temi visuali.</value>
</property>
<property key="WebtoolsLeaveAllEntriesBlank">
<value xml:lang="de">alle Einträge leer lassen</value>

Modified: ofbiz/trunk/framework/webtools/widget/MiscScreens.xml
URL:

http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/MiscScreens.xml?rev=1065018&r1=1065017&r2=1065018&view=diff

==============================================================================

--- ofbiz/trunk/framework/webtools/widget/MiscScreens.xml (original)
+++ ofbiz/trunk/framework/webtools/widget/MiscScreens.xml Sat Jan 29
14:22:28 2011
@@ -111,6 +111,9 @@ under the License.
<container style="button-bar
button-style-1">
<!-- Typically used for
intra-app links -->
<link

target="${demoTargetUrl}" text="${uiLabelMap.CommonNew}" style="create"/>

+<link target="${demoTargetUrl}" text="${uiLabelMap.CommonDelete}"
style="delete"/>
+<link target="${demoTargetUrl}" text="${uiLabelMap.CommonRefresh}"
style="refresh"/>
+<link target="${demoTargetUrl}" text="${uiLabelMap.CommonSearch}"
style="search"/>
<link
target="${demoTargetUrl}" text="${uiLabelMap.CommonSelected}"
style="selected"/>
<link
target="${demoTargetUrl}" text="${uiLabelMap.CommonEnabled}"/>
<link
text="${uiLabelMap.CommonDisabled}" style="disabled"/>
@@ -118,6 +121,9 @@ under the License.
<container style="button-bar
button-style-2">
<!-- Typically used for
inter-app links -->
<link

target="${demoTargetUrl}" text="${uiLabelMap.CommonNew}" style="create"/>

+<link target="${demoTargetUrl}" text="${uiLabelMap.CommonDelete}"
style="delete"/>
+<link target="${demoTargetUrl}" text="${uiLabelMap.CommonRefresh}"
style="refresh"/>
+<link target="${demoTargetUrl}" text="${uiLabelMap.CommonSearch}"
style="search"/>
<link
target="${demoTargetUrl}" text="${uiLabelMap.CommonSelected}"
style="selected"/>
<link
target="${demoTargetUrl}" text="${uiLabelMap.CommonEnabled}"/>
<link
text="${uiLabelMap.CommonDisabled}" style="disabled"/>
@@ -127,12 +133,12 @@ under the License.
<section name="h1-h6 Styles">
<widgets>
<horizontal-separator/>
-<label style="h1" text="${demoText}"/>
-<label style="h2" text="${demoText}"/>
-<label style="h3" text="${demoText}"/>
-<label style="h4" text="${demoText}"/>
-<label style="h5" text="${demoText}"/>
-<label style="h6" text="${demoText}"/>
+<label style="h1" text="${demoText} (h1)"/>
+<label style="h2" text="${demoText} (h2)"/>
+<label style="h3" text="${demoText} (h3)"/>
+<label style="h4" text="${demoText} (h4)"/>
+<label style="h5" text="${demoText} (h5)"/>
+<label style="h6" text="${demoText} (h6)"/>
</widgets>
</section>
<section name="Form/List Styles">