[
https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990351#comment-12990351
]
Sergei commented on OFBIZ-4165:
-------------------------------
List orderAdjustments = new ArrayList();
for (long itr = 1; itr <= groupIndex; itr++) {
shipGroupSeqId = UtilFormatOut.formatPaddedNumber(itr, 5);
List<GenericValue> removeList = new ArrayList<GenericValue>();
for (GenericValue stored: (List<GenericValue>)toStore) {
if ("OrderAdjustment".equals(stored.getEntityName())) {
if
(("SHIPPING_CHARGES".equals(stored.get("orderAdjustmentTypeId")) ||
"SALES_TAX".equals(stored.get("orderAdjustmentTypeId"))) &&
stored.get("orderId").equals(orderId) &&
stored.get("shipGroupSeqId").equals(shipGroupSeqId)) {
// Removing objects from toStore list for old Shipping
and Handling Charges Adjustment and Sales Tax Adjustment.
removeList.add(stored);
}
if (stored.get("comments") != null &&
((String)stored.get("comments")).startsWith("Added manually by")) {
// Removing objects from toStore list for Manually
added Adjustment.
removeList.add(stored);
}
}
}
toStore.removeAll(removeList);
}
> Omission in the OrderService
> ----------------------------
>
> Key: OFBIZ-4165
> URL: https://issues.apache.org/jira/browse/OFBIZ-4165
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Sergei
> Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping
> groups, the result of the updating without any changes is the duplication of
> the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at
> the patch.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
