[ 
https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023122#comment-13023122
 ] 

Jacques Le Roux commented on OFBIZ-4259:
----------------------------------------

Hi Nicolas,

OK, we still need to

* Put info from 
[FAMFAMFAM.license.txt|http://www.corda.ac/MOVE0904/img/famfamfam/FAMFAMFAM.license.txt
 ] in NOTICE file and put a mention about [CREATIVE 
COMMONS|http://creativecommons.org/licenses/by/2.5/legalcode ] in LICENSE, [see 
why here|http://www.apache.org/legal/resolved.html#cc-sa]
* I suggest to put the famfamfam icons in a famfamfam folder under images

Could you please take care of that?

Icons.jpg looks great :) Small change big effect

TIA

> Add famfamfam icons has generic and add possibility to surchage
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-4259
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4259
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, themes
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>              Labels: icons, images
>             Fix For: SVN trunk
>
>         Attachments: Icons.jpg, OFBIZ-4259.patch, famfamfam.zip
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> I add possibility to use famfamfam icons contains in 
> framework/images/webapp/images/icons.
> If you want use specific icon, it's possible to define a attribute 
> VT_ICONS_LOC that contains the way to themes icons directory to use
> I improve form renderer to passe a flexible string on image-location 
> attribute and screen and form renderer to display an image with a text.
> To try it, deploy famfamfam.zip on framework/images/webapp/images directory, 
> apply the patch and go to exemple component (see screenshot ;) )

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to