[
https://issues.apache.org/jira/browse/OFBIZ-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054516#comment-13054516
]
Jacques Le Roux commented on OFBIZ-4326:
----------------------------------------
Hi Stéphane,
A best practice is to use the same name for patches. As you can se, Jira will
gray the old ones. Hence it's easier for us to pick the right one w/out
referring to comments. Also, though it's not mandatory, we like to have patches
prefixed with the Jira number and named with the title of the issue, eg
{code}
OFBIZ-4257_add_a_parameter_to_forbid_order_decimal_quantity.patch
OFBIZ-4235-ShoppingCartItem.java.patch
OFBIZ-4213_Add compilerarg value=-Xlint.patch
{code}
I'd not ask you that if I'd not have seen that you were contiously contributing
these last times ;)
Thanks for your contributions!
> VAT Correction for ProductPrice that has priceWithTax =N is not correct (with
> patch)
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-4326
> URL: https://issues.apache.org/jira/browse/OFBIZ-4326
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Stéphane DUCAS
> Priority: Minor
> Attachments: vatCorrection.patch, vatCorrection_2.patch,
> vatCorrection_2.patch
>
>
> The VAT correction adjustment is not correct because it's based on the price
> not rounded (while tax adjustment is calculated from the rounded price).
> I provide the patch for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
