[
https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056862#comment-13056862
]
Jacques Le Roux commented on OFBIZ-4327:
----------------------------------------
Hi BJ,
Some remarks after a quick review:
# Minor: bad indentation and formatting in ControlServlet.java, for instance
{code}
if(VisitHandler.filterVisitor(request, response)==Boolean.TRUE){
{code}
should be
{code}
if (VisitHandler.filterVisitor(request, response) == Boolean.TRUE) {
{code}
# You use tabs in your patch.
# I did not see a mean to deactivate this option (for instance if you already
filter with HTTPD in front)
> deny list
> ---------
>
> Key: OFBIZ-4327
> URL: https://issues.apache.org/jira/browse/OFBIZ-4327
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Affects Versions: SVN trunk
> Reporter: BJ Freeman
> Priority: Minor
> Labels: deny, list, obiz
> Attachments: OFBIZ-4327.patch, OFBIZ-4327.patch, VisitFllter.xml,
> VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are
> allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known
> to attempt to hack, or do unnecessary requests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
