Thank you for your comments Adam, we will look into it.
Regards, Hans On Thu, 2011-07-07 at 19:22 -0500, Adam Heath wrote: > I have some comments in-line. > > On 07/05/2011 03:15 AM, hans...@apache.org wrote: > > Author: hansbak > > Date: Tue Jul 5 08:15:32 2011 > > New Revision: 1142915 > > > > URL: http://svn.apache.org/viewvc?rev=1142915&view=rev > > Log: > > add support for the scrum framework donated by Antwebsystems > Co.Ltd. more info at: > http://www.antwebsystems.com/control/ViewBlogArticle?articleContentId=21140&blogContentId=AWS_BLOG > > > > Added: ofbiz/trunk/specialpurpose/scrum/README.txt > > URL: > http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/scrum/README.txt?rev=1142915&view=auto > > > ============================================================================== > > --- ofbiz/trunk/specialpurpose/scrum/README.txt (added) > > +++ ofbiz/trunk/specialpurpose/scrum/README.txt Tue Jul 5 08:15:32 > 2011 > > @@ -0,0 +1,42 @@ > > +How to install the revision of task function. > > +============================================= > > + > > +Server requirements > > +1. subversion > > +2. libapache2-mod-python > > It'd be nice if this component wasn't hard-coded to subversion. It sucks. > > There is a java library for dealing with subversion. Why didn't you > use that, instead of calling svn using Process, then processing the > command output? > > Processing command output will fail, if someone ever changes the > default locale for ofbiz startup. In such cases, the output from svn > will change, and your parsing will break. This can be fixed, if you > use ProcessBuilder, and set the correct environment settings. However, > that is not cross-platform. > > Best to just use the subversion java library. > > > + > > +Installation (On server) > > + > > +1. Install subversion > > +2. Hook script setting > > + 2.1 post-commit file is hook script file that will work when > users commit source code to subversion repository. > > + Copy post-commit file from > "scrum/data/hookscripts/post-commit" to hooks folder of repository and > then edit file following : > > + Example : python > /usr/share/subversion/hook-scripts/commit.py "$REPOS" "$REV" > > + 2.2 commit.py file is python file which will send revision > information to Scrum web service. > > + Copy commit.py from "scrum/data/hookscripts/commit.py" > to "/usr/share/subversion/hook-scripts/" and then edit file following : > > + > --------------------------------------------------------------------------------- > > + CONFIG_PATH = "" // the path of the > revision.properties should begin from home directory. > > + Example : CONFIG_PATH = > "/home/ofbiz/ofbiz/hot-deploy/scrum/config/revision.properties" > > + > -------------------------------------------------------------------------------- > > +3. Configure file setting : The original configure file is in > scrum component (/scrum/config/revision.properties) you can put it > > + anywhere that you wish but should be set the path of the > file in commit.py file ("CONFIG_PATH="). > > + Example: > > + > -------------------------------------------------------------------------------- > > + revision.url =https://www.antwebsystems.com/svn/ > > + ofbiz.webservice.url > =http://www.antwebsystems.com/webtools/control/SOAPService > > + host.name =www.antwebsystems.com > > + host.port =80 > > Do not include example links to your company. Anonymize them to be > www.example.com, or example.ofbiz.org. > > > + > > + #-- subversion admin and password > > + svn.user=harry > > + svn.password=harryssecret > > I would personally use "user" and "password", but this is not a big > problem for me. > > > + > -------------------------------------------------------------------------------- > > +4. Change the location path of the updateScrumRevision service in > .../scrum/servicedef/services.xml file. > > + Example: > > + > -------------------------------------------------------------------------------- > > +<service name="updateScrumRevision" engine="soap" export="true" > > + > location="http://www.antwebsystems.com/webtools/control/SOAPService"; > invoke="updateScrumRevisionChange"> // the same as ofbiz.webservice.url > > +<implements service="updateScrumRevisionChange"/> > > +</service> > > + > -------------------------------------------------------------------------------- > > +5. Restart the server. > > > > Added: ofbiz/trunk/specialpurpose/scrum/config/revision.properties > > URL: > http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/scrum/config/revision.properties?rev=1142915&view=auto > > > ============================================================================== > > --- ofbiz/trunk/specialpurpose/scrum/config/revision.properties (added) > > +++ ofbiz/trunk/specialpurpose/scrum/config/revision.properties Tue > Jul 5 08:15:32 2011 > > @@ -0,0 +1,34 @@ > > > +############################################################################### > > +# Licensed to the Apache Software Foundation (ASF) under one > > +# or more contributor license agreements. See the NOTICE file > > +# distributed with this work for additional information > > +# regarding copyright ownership. The ASF licenses this file > > +# to you under the Apache License, Version 2.0 (the > > +# "License"); you may not use this file except in compliance > > +# with the License. You may obtain a copy of the License at > > +# > > +# http://www.apache.org/licenses/LICENSE-2.0 > > +# > > +# Unless required by applicable law or agreed to in writing, > > +# software distributed under the License is distributed on an > > +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > > +# KIND, either express or implied. See the License for the > > +# specific language governing permissions and limitations > > +# under the License. > > > +############################################################################### > > + > > +# -- The section > > +[config] > > +# -- revision url example : https://www.antwebsystems.com/svn/ > > +revision.url=https://www.antwebsystems.com/svn/ > > This pattern is broken. The java files are hard-coded to look for the > ending "svn/", which is a restriction that should not be. The java > code is also broken, in that it'll match a string that is "-svn/", > which is not what I think you want. > > > + > > +# -- The OFBiz Web Service url > > > +ofbiz.webservice.url=http://www.antwebsystems.com/webtools/control/SOAPService > > + > > +# -- the Host name should be the name of host or by default > "localhost" > > +host.name=www.antwebsystems.com > > +host.port=80 > > + > > +# -- subversion user and password > > +svn.user=general > > +svn.password=general23 > > Do not include example links to your company. Anonymize them to be > www.example.com, or example.ofbiz.org. > > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates.
