[
https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084202#comment-13084202
]
Jacques Le Roux commented on OFBIZ-4242:
----------------------------------------
Lon,
First thing, your patch is done for 9.04 we don't apply patches on releases but
bug. This is not a bug but an improvement. COuld you please redo your patch
against trunk?
Also there are tabs in your patch, please follow
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices
closely.
You duplicated the JavaDoc for containsString(final String fileName, from
public static boolean containsString(Reader reader, final String searchString)
w/out changing some infos
Thanks
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional
> {{<distributable/>}} node to indicate that the application is clusterable.
> Currently, OFBiz does not respect this setting and assumes all applications
> should be distributed if any cluster configuration is provided in the
> {{ofbiz-containers.xml}} file. As a result, if, for example, the
> {{DeltaManager}} is enable, all applications attempt to cluster and
> communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual
> application's web.xml file for the {{<distributable/>}} node and only use the
> {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used
> for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
