[
https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-4391:
-----------------------------------
Attachment: OFBIZ-4391_loadCartFromQuote.patch
Mmm,
I got some issues so far,
* on demo trunk (I neglicted the NPE fixed at r1165233, it will be soon
updated/fixed aldo on demo), when I create the order I get
"Did not complete the order, the following occurred:ERROR: There are no items
to order" which seems actualy due to "Totals do not match order total."
* locally patched, I get a NPE when creating the order
{code}
2011-09-06 07:08:17,328 (http-0.0.0.0-8443-3) [
RequestHandler.java:167:INFO ] [RequestHandler]: Chain in place:
requestUri=processpayment overrideViewUri=null
sessionId=B4432EB539E9CE2032AC0E9A6B6FB5
vm1
2011-09-06 07:08:17,328 (http-0.0.0.0-8443-3) [
JavaEventHandler.java:101:ERROR]
---- runtime exception report --------------------------------------------------
Problems Processing Event
Exception: java.lang.NullPointerException
Message: null
---- stack trace ---------------------------------------------------------------
java.lang.NullPointerException
org.ofbiz.order.shoppingcart.CheckOutEvents.processPayment(CheckOutEvents.java:567)
org.ofbiz.order.shoppingcart.CheckOutEvents.processPayment(CheckOutEvents.java:535)
{code}
I will check that later. For the moment here is a patch amended (formatting):
* no spaces after bracket
* when you don't use curly brackets after if/else then please put the
expression on the same line than the if/else. It avoids troubles later, as it's
clear the unique expression is related to the if/else
> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
> Key: OFBIZ-4391
> URL: https://issues.apache.org/jira/browse/OFBIZ-4391
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: rev 1164344
> Reporter: Paul Foxworthy
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: cart, order, quote, tax
> Attachments: OFBIZ-4391_loadCartFromQuote.patch,
> OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the
> order-wide adjustments for the shopping cart. Tax adjustments should be
> copied into the shipping group, i.e. treated in a different way from
> adjustments like a discount.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
