[ 
https://issues.apache.org/jira/browse/OFBIZ-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107806#comment-13107806
 ] 

Paul Foxworthy commented on OFBIZ-4427:
---------------------------------------

https://fisheye6.atlassian.com/browse/~br=trunk/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java?r=1170525#to614
 has a call to UtilValidate.isEmpty with appDefaultLocale, which was declared 
as Object. Can it be tightened to String? The call at 
https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/src/org/ofbiz/product/store/ProductStoreWorker.java?r=1044931#to111
 passes a String.

And thanks, Adrian. At a guess most of the 166 calls will be OK so there are a 
manageable number to fix.

> Possible runtime errors with UtilValidate.isEmpty(Object) should be rather 
> caught during compilation
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4427
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4427
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>              Labels: UtilValidate.isEmpty
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4427.patch
>
>
> Hence we need tp remove the UtilValidate.isEmpty(Object) method and provide 
> methods that accept explicit types.  
> Scripting languages should use a facade class that provides methods for 
> working with generic Objects or providing default behaviors.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to