[
https://issues.apache.org/jira/browse/OFBIZ-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109516#comment-13109516
]
Sascha Rodekamp commented on OFBIZ-4436:
----------------------------------------
Hi Kiran,
that's really true we have a code duplication here.
The question is if we should include the UpdateCart in the OnePageCheckOut Ftl,
i can imagine, that this can confuse developers. I.e. when someone changes the
updateCart FTL and he don't notice that we have a relation to the
OnePageCheckOut. That could possible break the OPCO, got my point?
I would prefer to create a generic FTL called ShoppingCartCheckOutFirstStep.ftl
(i think we could find a shorter/better name), place the Step 1 code in the new
file and include this one in the UpdateCart and the OPCO.
Any opinions?
> OnePageCheckout should reuse UpdateCart while first time rendering
> ------------------------------------------------------------------
>
> Key: OFBIZ-4436
> URL: https://issues.apache.org/jira/browse/OFBIZ-4436
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 11.04
> Reporter: Kiran Gawde
> Assignee: Sascha Rodekamp
> Priority: Minor
> Attachments: OFBIZ-4436-OrderScreensXml.patch,
> OFBIZ-4436-UpdateCartReuse.patch
>
>
> When shipping options or coupon are changed the entire cart is updated by
> invoking UpdateCart. It returns output of UpdateCart screen. The same screen
> should be reused during original rendering to avoid code duplication.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
