Re: svn commit: r1142458 - in /ofbiz/trunk/framework/common: webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy widget/CommonScreens.xml

Sun, 23 Oct 2011 11:53:32 -0700

I don't see anything in this commit that would generate that error. With this commit, autocompleterViewSize = 10. Without this commit, autocompleterViewSize = 10. There is no difference. 

-Adrian

On 10/23/2011 7:20 PM, Jacques Le Roux wrote:
Actually I forgot to revert a try I made, the real log you should get is (not much different on line number in FindAutocompleteOptions.groovy):
2011-10-23 20:16:08,562 (http-0.0.0.0-8443-2) [ GenericDelegator.java:1787:ERROR] ---- exception report ---------------------------------------------------------- Failure in findByCondition operation for entity [ProductCategory]: org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the following:SELECT PRODUCT_CATEGORY_ID, CATEGORY_NAME, DESCRIPTI ON FROM OFBIZ.PRODUCT_CATEGORY WHERE (((PRODUCT_CATEGORY_ID = (?, ?) OR PRODUCT_CATEGORY_ID = (?, ?) OR PRODUCT_CATEGORY_ID = (?, ?)))) ORDER BY PRODUCT_CATEGORY_ID ASC, CATEGORY_NAME ASC, DESCRIPTION ASC (Sy ntax error: Encountered "," at line 1, column 117.). Rolling back transaction. 
Exception: org.ofbiz.entity.GenericDataSourceException
Message: SQL Exception while executing the following:SELECT PRODUCT_CATEGORY_ID, CATEGORY_NAME, DESCRIPTION FROM OFBIZ.PRODUCT_CATEGORY WHERE (((PRODUCT_CATEGORY_ID = (?, ?) OR PRODUCT_CATEGORY_ID = (?, ?) OR PRODUCT_CATEGORY_ID = (?, ?)))) ORDER BY PRODUCT_CATEGORY_ID ASC, CATEGORY_NAME ASC, DESCRIPTION ASC (Syntax error: Encountered "," at line 1, column 117.) ---- cause --------------------------------------------------------------------- 
Exception: java.sql.SQLSyntaxErrorException
Message: Syntax error: Encountered "," at line 1, column 117.
---- cause --------------------------------------------------------------------- 
Exception: org.apache.derby.impl.jdbc.EmbedSQLException
Message: Syntax error: Encountered "," at line 1, column 117.
---- cause --------------------------------------------------------------------- 
Exception: org.apache.derby.iapi.error.StandardException
Message: Syntax error: Encountered "," at line 1, column 117.
---- stack trace --------------------------------------------------------------- 
ERROR 42X01: Syntax error: Encountered "," at line 1, column 117.
org.apache.derby.iapi.error.StandardException.newException(Unknown Source) org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown Source) 
org.apache.derby.impl.sql.GenericStatement.prepMinion(Unknown Source)
org.apache.derby.impl.sql.GenericStatement.prepare(Unknown Source)
org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext.prepareInternalStatement(Unknown Source) 
org.apache.derby.impl.jdbc.EmbedPreparedStatement.<init>(Unknown Source)
org.apache.derby.impl.jdbc.EmbedPreparedStatement20.<init>(Unknown Source) org.apache.derby.impl.jdbc.EmbedPreparedStatement30.<init>(Unknown Source) org.apache.derby.impl.jdbc.EmbedPreparedStatement40.<init>(Unknown Source) 
org.apache.derby.jdbc.Driver40.newEmbedPreparedStatement(Unknown Source)
org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown Source) org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown Source) org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:291) org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:291) org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:363) org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java:770) org.ofbiz.entity.datasource.GenericHelperDAO.findListIteratorByCondition(GenericHelperDAO.java:145) 
org.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1743)
org.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1775)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) 
java.lang.reflect.Method.invoke(Method.java:597)
org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoCachedMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:229) org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:52) org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:40) org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:116) 
FindAutocompleteOptions.run(FindAutocompleteOptions.groovy:117)

Jacques

From: "Jacques Le Roux" <[email protected]>
As it's explained in OFBIZ-4498, uses https://demo-trunk.ofbiz.apache.org:8443/catalog/control/ProductStoreFacilities?productStoreId=9000, then have a look into log 
You should see something like
Failure in findByCondition operation for entity [ProductCategory]: org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the following:SELECT PRODUCT_CATEGORY_ID, CATEGORY_NAME, DESCRIPTI ON FROM OFBIZ.PRODUCT_CATEGORY WHERE (((PRODUCT_CATEGORY_ID = (?, ?) OR PRODUCT_CATEGORY_ID = (?, ?) OR PRODUCT_CATEGORY_ID = (?, ?)))) ORDER BY PRODUCT_CATEGORY_ID ASC, CATEGORY_NAME ASC, DESCRIPTION ASC (Sy ntax error: Encountered "," at line 1, column 117.). Rolling back transaction. 
Exception: org.ofbiz.entity.GenericDataSourceException
Message: SQL Exception while executing the following:SELECT PRODUCT_CATEGORY_ID, CATEGORY_NAME, DESCRIPTION FROM OFBIZ.PRODUCT_CATEGORY WHERE (((PRODUCT_CATEGORY_ID = (?, ?) OR PRODUCT_CATEGORY_ID = (?, ?) OR PRODUCT_CATEGORY_ID = (?, ?)))) ORDER BY PRODUCT_CATEGORY_ID ASC, CATEGORY_NAME ASC, DESCRIPTION ASC (Syntax error: Encountered "," at line 1, column 117.) ---- cause --------------------------------------------------------------------- 
Exception: java.sql.SQLSyntaxErrorException
Message: Syntax error: Encountered "," at line 1, column 117.
---- cause --------------------------------------------------------------------- 
Exception: org.apache.derby.impl.jdbc.EmbedSQLException
Message: Syntax error: Encountered "," at line 1, column 117.
---- cause --------------------------------------------------------------------- 
Exception: org.apache.derby.iapi.error.StandardException
Message: Syntax error: Encountered "," at line 1, column 117.
---- stack trace --------------------------------------------------------------- 
ERROR 42X01: Syntax error: Encountered "," at line 1, column 117.
org.apache.derby.iapi.error.StandardException.newException(Unknown Source) org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown Source) 
org.apache.derby.impl.sql.GenericStatement.prepMinion(Unknown Source)
org.apache.derby.impl.sql.GenericStatement.prepare(Unknown Source)
org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext.prepareInternalStatement(Unknown Source) 
org.apache.derby.impl.jdbc.EmbedPreparedStatement.<init>(Unknown Source)
org.apache.derby.impl.jdbc.EmbedPreparedStatement20.<init>(Unknown Source) org.apache.derby.impl.jdbc.EmbedPreparedStatement30.<init>(Unknown Source) org.apache.derby.impl.jdbc.EmbedPreparedStatement40.<init>(Unknown Source) 
org.apache.derby.jdbc.Driver40.newEmbedPreparedStatement(Unknown Source)
org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown Source) org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown Source) org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:291) org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:291) org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:363) org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java:770) org.ofbiz.entity.datasource.GenericHelperDAO.findListIteratorByCondition(GenericHelperDAO.java:145) 
org.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1743)
org.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1775)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) 
java.lang.reflect.Method.invoke(Method.java:597)
org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoCachedMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:229) org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:52) org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:40) org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:116) 
FindAutocompleteOptions.run(FindAutocompleteOptions.groovy:112)

Not sure it was correct before, but this was not thrown

Jacques

From: "Adrian Crum" <[email protected]>

Could you describe what the bug is and how I can reproduce it?

-Adrian

On 10/23/2011 1:11 PM, Jacques Le Roux wrote:

Hi Adrian,
While working on https://issues.apache.org/jira/browse/OFBIZ-4498 I found a bug related to r1142458 (only shown in log). If you revert the commit it dissapears. Note that it's not the the cause of OFBIZ-4498 which is related to r1130415 

When you get a chance, please have a look at r1142458

Thanks

Jacques



Author: adrianc
Date: Sun Jul  3 16:48:56 2011
New Revision: 1142458

URL: http://svn.apache.org/viewvc?rev=1142458&view=rev
Log:
Minor Ajax code improvement: The autocompleterViewSize widget.properties setting can be overridden in a screen. 

Modified:
ofbiz/trunk/framework/common/webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy 
   ofbiz/trunk/framework/common/widget/CommonScreens.xml
Modified: ofbiz/trunk/framework/common/webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy?rev=1142458&r1=1142457&r2=1142458&view=diff ============================================================================== --- ofbiz/trunk/framework/common/webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy (original) +++ ofbiz/trunk/framework/common/webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy Sun Jul 3 16:48:56 2011 
@@ -19,6 +19,7 @@

import org.ofbiz.base.util.StringUtil;
import org.ofbiz.base.util.Debug;
+import org.ofbiz.base.util.UtilProperties;
import org.ofbiz.entity.util.EntityFindOptions;
import org.ofbiz.entity.condition.EntityCondition;
import org.ofbiz.entity.condition.EntityConditionList;
@@ -104,7 +105,11 @@ if (orExprs && entityName && displayFiel
def entityConditionList = EntityCondition.makeCondition(mainAndConds, EntityOperator.AND);
- Integer autocompleterViewSize = Integer.valueOf(context.autocompleterViewSize ?: 10); 
+    String viewSizeStr = context.autocompleterViewSize;
+    if (viewSizeStr == null) {
+ viewSizeStr = UtilProperties.getPropertyValue("widget", "widget.autocompleter.defaultViewSize"); 
+    }
+ Integer autocompleterViewSize = Integer.valueOf(viewSizeStr ?: 10); 
    EntityFindOptions findOptions = new EntityFindOptions();
    findOptions.setMaxRows(autocompleterViewSize);
    findOptions.setDistinct(searchDistinct);

Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=1142458&r1=1142457&r2=1142458&view=diff ============================================================================== 
--- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
+++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Sun Jul 3 16:48:56 2011 
@@ -348,7 +348,6 @@ under the License.
<section>
<actions>
<set field="searchType" from-field="parameters.searchType" default-value="${searchType}"/> - <property-to-field resource="widget" property="widget.autocompleter.defaultViewSize" field="autocompleterViewSize"/> <script location="component://common/webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy"/> 
</actions>
<widgets>

Reply via email to