My vote would be to re-enable them regardless, the whole point of the tests is
to ensure stability and disabling tests that (allegedly) fail does nothing to
further that goal.
The correct approach is to find the commit that caused the failure and make a
lot of noise to that committer. I'm pretty sure that everyone agrees that we
have a responsibility as committers to ensure that we won't cause the tests to
fail.
Regards
Scott
On 15/12/2011, at 6:46 AM, Jacopo Cappellato wrote:
> No problem: can I re-enable the tests in the meantime?
>
> Jacopo
>
> On Dec 15, 2011, at 2:30 PM, Hans Bakker wrote:
>
>> At the moment pretty busy with other things, will have time this weekend or
>> next week,
>>
>> On 12/15/2011 08:28 PM, Jacopo Cappellato wrote:
>>> Hi Hans,
>>>
>>> any update on this?
>>>
>>> Thanks,
>>>
>>> Jacopo
>>>
>>> On Dec 14, 2011, at 9:37 AM, Jacopo Cappellato wrote:
>>>
>>>> Hi Hans,
>>>>
>>>> please see inline:
>>>>
>>>> On Dec 14, 2011, at 8:55 AM, Hans Bakker wrote:
>>>>
>>>>> Hi Jacopo,
>>>>>
>>>>> thank you for looking into this.
>>>>>
>>>>> yes sure i did run ./ant run-install
>>>>>
>>>>> The test below needs some OrderItemBilling records for order DEMO10091
>>>>> which specifies an invoiceId.
>>>>> these records are however not there and therefore the invoiceId is
>>>>> missing.
>>>>> I can also not find them anywhere in demo or test data....
>>>> I think the invoice (and OrderItemBilling record) is created by the chain
>>>> of events caused by the test before that one: testAcctgTransOnPoReceipts
>>>> (receipt-->shipment-->invoice)
>>>>
>>>>> Then i disabled only the test below, and then all following tests in the
>>>>> same file are failing.
>>>> Of course they are, because the tests in that group rely on each other.
>>>>
>>>>> Then I went back to a much earlier revision where the tests are failing
>>>>> too....A revision where i found them working is 892749 from 2009-12-21 .
>>>>> So they seem to be working before...
>>>>>
>>>>> did you try to run the ./ant run-tests locally ? It looks like buildbot
>>>>> is missing these tests....
>>>>>
>>>> Yes, I tested the tests locally:
>>>> ant clean-all
>>>> ant run-install
>>>> ant run-tests
>>>>
>>>> Jacopo
>>>>
>>>>> Regards,
>>>>> Hans
>>>>>
>>>>> On 12/14/2011 01:56 PM, Jacopo Cappellato wrote:
>>>>>> Hans,
>>>>>>
>>>>>> did you run "ant run-install" before "ant run-tests"?
>>>>>>
>>>>>> I suspect that you are getting this error because in your db the order
>>>>>> DEMO10091 is not found.
>>>>>>
>>>>>> Jacopo
>>>>>>
>>>>>> On Dec 13, 2011, at 4:56 PM, Hans Bakker wrote:
>>>>>>
>>>>>>> Hi Jacopo,
>>>>>>>
>>>>>>> this is what is reported:
>>>>>>>
>>>>>>> Error Message
>>>>>>>
>>>>>>> ERROR: Could not complete the Test case for Purchase Invoices: editing,
>>>>>>> adding taxes and shipping charges and posting to GL
>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map
>>>>>>> named [serviceCtx] containing
>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13
>>>>>>> 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>> 00:11:52.971(java.sql.Timestamp)][lastU
>>>>>>> pdatedTxStamp,2011-12-13
>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required
>>>>>>> parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>
>>>>>>> Stacktrace
>>>>>>>
>>>>>>> junit.framework.AssertionFailedError: ERROR: Could not complete the
>>>>>>> Test case for Purchase Invoices: editing, adding taxes and shipping
>>>>>>> charges and posting to GL
>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map
>>>>>>> named [serviceCtx] containing
>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13
>>>>>>> 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>> 0
>>>>>>> 0:11:52.971(java.sql.Timestamp)][lastUpdatedTxStamp,2011-12-13
>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required
>>>>>>> parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>> at
>>>>>>> org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:93)
>>>>>>> at
>>>>>>> org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>>>>>>> at
>>>>>>> org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>>>>>>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>>>>>>> at org.ofbiz.base.start.Start.start(Start.java:289)
>>>>>>> at org.ofbiz.base.start.Start.main(Start.java:119)
>>>>>>>
>>>>>>>
>>>>>>> Regards,
>>>>>>> Hans
>>>>>>>
>>>>>>>
>>>>>>> On 12/13/2011 10:52 PM, Jacopo Cappellato wrote:
>>>>>>>> Hans,
>>>>>>>>
>>>>>>>> could you please be more specific on the errors/failures you are
>>>>>>>> getting?
>>>>>>>> It seems I was able to run successfully all the tests.
>>>>>>>>
>>>>>>>> Jacopo
>>>>>>>>
>>>>>>>> On Dec 13, 2011, at 3:41 PM, Hans Bakker wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>> Yes a good idea:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-4624
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Hans
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 12/13/2011 09:21 PM, Erwan de FERRIERES wrote:
>>>>>>>>>
>>>>>>>>>> Hans,
>>>>>>>>>>
>>>>>>>>>> could you create an associated Jira issue, so this won't be
>>>>>>>>>> forgotten ?
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>>
>>>>>>>>>> 2011/12/13
>>>>>>>>>> <[email protected]>
>>>>>>>>>> :
>>>>>>>>>>
>>>>>>>>>>> Author: hansbak
>>>>>>>>>>> Date: Tue Dec 13 11:04:57 2011
>>>>>>>>>>> New Revision: 1213650
>>>>>>>>>>>
>>>>>>>>>>> URL:
>>>>>>>>>>> http://svn.apache.org/viewvc?rev=1213650&view=rev
>>>>>>>>>>>
>>>>>>>>>>> Log:
>>>>>>>>>>> commented out accounting auto tests which did not work for a long
>>>>>>>>>>> time
>>>>>>>>>>>
>>>>>>>>>>> Modified:
>>>>>>>>>>> ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>
>>>>>>>>>>> Modified:
>>>>>>>>>>> ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>> URL:
>>>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/testdef/accountingtests.xml?rev=1213650&r1=1213649&r2=1213650&view=diff
>>>>>>>>>>>
>>>>>>>>>>> ==============================================================================
>>>>>>>>>>> --- ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>> (original)
>>>>>>>>>>> +++ ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>> Tue Dec 13 11:04:57 2011
>>>>>>>>>>> @@ -29,7 +29,8 @@
>>>>>>>>>>>
>>>>>>>>>>> <test-case case-name="accounting-tests"><junit-test-suite
>>>>>>>>>>> class-name="org.ofbiz.accounting.test.FinAccountTests"/></test-case>
>>>>>>>>>>>
>>>>>>>>>>> -<test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>> +<!-- commented out for now...test data seems to be missing and i
>>>>>>>>>>> wondered if theyu ever worked, went back to rev: 903431 and ever
>>>>>>>>>>> there the same problem -->
>>>>>>>>>>> +<!-- test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>> <simple-method-test
>>>>>>>>>>> location="component://accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml"/>
>>>>>>>>>>> -</test-case>
>>>>>>>>>>> +</test-case-->
>>>>>>>>>>> </test-suite>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>
>
