[
https://issues.apache.org/jira/browse/OFBIZ-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-4693.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Release Branch 11.04
Release Branch 10.04
Assignee: Jacques Le Roux
Thanks Michael,
Your patch is in
trunk r1244139
R11.04 r1244140
R10.04 r1244148
It was easily applied (fortunately very simple) but not done following the
rules
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices
Notably a lot of false changes and not done from root folder.
For the false changes no pb it was only "trailing" blanks removed (at least
personnally I'm not agains, thanks to Subclipse which hides them). But then you
should better tell us. I know that sometimes it's a pain to have to switch this
setting on/off... Personally I tried to avoid those changes when it really
complicates the patch. This one was not.
> return value of currentDelegatorTenantId.trim() ignored in
> org.ofbiz.webapp.control.LoginWorker.login(HttpServletRequest,
> HttpServletResponse)
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4693
> URL: https://issues.apache.org/jira/browse/OFBIZ-4693
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Jacques Le Roux
> Labels: patch
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: LoginWorker.java.patch
>
>
> The return value of currentDelegatorTenantId.trim() is ignored in
> org.ofbiz.webapp.control.LoginWorker.login(HttpServletRequest,
> HttpServletResponse) so trim() has no effect.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
