[
https://issues.apache.org/jira/browse/OFBIZ-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233295#comment-13233295
]
Jacques Le Roux commented on OFBIZ-4627:
----------------------------------------
Hi Tri,
I just reviewed the CommonUiLabels.xml.patch and there is a problem. You remove
all and then add all again + your changes. This is not how it should be done
because it's impossible to review patches this way. You should apply your
patches on a local instance and create them again. There should be only
differences. Please have a look at another Jira issue where there is a patch,
for instance OFBIZ-4716, to see the expected results.
Thanks for your effort
Also when creating your patches create them from OFBiz root directory.
> contribute Ofbiz Vietnamese tranlasting to community from HaNoi
> ---------------------------------------------------------------
>
> Key: OFBIZ-4627
> URL: https://issues.apache.org/jira/browse/OFBIZ-4627
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Tri Duc Vo
> Assignee: Jacques Le Roux
> Labels: features
> Fix For: SVN trunk
>
> Attachments: CommonUiLabels.xml.patch, EcommerceUiLabels.xml,
> EcommerceUiLabels.xml.patch, MarketingUiLabels.xml.patch,
> OrderEntityLabels.xml.patch, OrderUiLabels.xml.patch,
> ProductEntityLabels.xml.patch, ProductUiLabels.xml, ProductUiLabels.xml.patch
>
> Original Estimate: 1,344h
> Remaining Estimate: 1,344h
>
> Dear Ofbiz community
> I'm Tri, from HaNoi, VietNam, and now our team build ERP based on Ofbiz
> opensource.
> Now we're completed translating 80% Ecommerce , 50% Catalog of Ofbiz. And
> we're going to complete 100% Vietnamese Ofbiz tranlasting and contribute them
> to community.
> We'll attach files soon
> Thank you
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
