[
https://issues.apache.org/jira/browse/OFBIZ-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234277#comment-13234277
]
Paul Foxworthy commented on OFBIZ-4627:
---------------------------------------
Hello Tri,
Thank you very much for your contribution.
What we mean by "create patches from the root directory" is described in
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices
In particular this part:
We prefer that you build your patch from the root as it's easier for commiters
to merge your change. So please make your patch files from the OFBIZ_HOME
directory (usually ofbiz/) and with relative file paths.
"Relative file paths" means that in your patch file names should look like
these :
applications/party/widget/partymgr/PartyScreens.xml
framework/webtools/config/WebtoolsErrorUiLabels.properties
and should not have file names like:
C:\myfiles\ofbiz\applications\party\widget\partymgr\PartyScreens.xml
The idea behind this is that maintainers can apply a patch to several different
parts of OFBiz without having to first navigate to the specific directory that
contains the file to be patched. If every contributor makes it easier to apply
patches, a committer is more likely to do so and put our hard work into the
trunk revision of OFBiz.
Your patches have just the file name without any path, so I presume you are
creating them by doing a diff on the actual file that you've changed. Try doing
a diff on the ofbiz directory instead, and see if you get relative paths in the
patch file.
This is really not very important, just making it a little easier for
committers. I am sure the OFBiz community would prefer to have your patches
even if the file name is not ideal. I really appreciate your efforts and I'm
pleased to see Vietnamese support added to OFBiz.
Cheers
Paul Foxworthy
> contribute Ofbiz Vietnamese tranlasting to community from HaNoi
> ---------------------------------------------------------------
>
> Key: OFBIZ-4627
> URL: https://issues.apache.org/jira/browse/OFBIZ-4627
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Tri Duc Vo
> Assignee: Jacques Le Roux
> Labels: features
> Fix For: SVN trunk
>
> Attachments: CommonUiLabels.xml.patch, CommonUiLabels.xml.patch,
> CommonUiLabels.xml.patch, CommonUiLabels.xml.patch, EcommerceUiLabels.xml,
> EcommerceUiLabels.xml.patch, EcommerceUiLabels.xml.patch,
> EcommerceUiLabels.xml.patch, EcommerceUiLabels.xml.patch,
> MarketingUiLabels.xml.patch, MarketingUiLabels.xml.patch,
> MarketingUiLabels.xml.patch, MarketingUiLabels.xml.patch,
> OrderEntityLabels.xml.patch, OrderEntityLabels.xml.patch,
> OrderEntityLabels.xml.patch, OrderEntityLabels.xml.patch,
> OrderUiLabels.xml.patch, OrderUiLabels.xml.patch, OrderUiLabels.xml.patch,
> OrderUiLabels.xml.patch, ProductEntityLabels.xml.patch,
> ProductEntityLabels.xml.patch, ProductEntityLabels.xml.patch,
> ProductEntityLabels.xml.patch, ProductUiLabels.xml,
> ProductUiLabels.xml.patch, ProductUiLabels.xml.patch,
> ProductUiLabels.xml.patch, ProductUiLabels.xml.patch
>
> Original Estimate: 1,344h
> Remaining Estimate: 1,344h
>
> Dear Ofbiz community
> I'm Tri, from HaNoi, VietNam, and now our team build ERP based on Ofbiz
> opensource.
> Now we're completed translating 80% Ecommerce , 50% Catalog of Ofbiz. And
> we're going to complete 100% Vietnamese Ofbiz tranlasting and contribute them
> to community.
> We'll attach files soon
> Thank you
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
