For me, it makes happy when code get cleaned as we go.
On Thu, Mar 29, 2012 at 4:55 PM, Erwan de FERRIERES <[email protected]> wrote: > Hi, > > from ProductDisplayWorker.java, lines 171-176, there is an array used, which > contains only one value. Is it OK with you to remove this declaration and > simplify the code ? > > Regards, > > // get all order role entities for user by customer role type > // final String[] USER_ORDER_ROLE_TYPES = > {"END_USER_CUSTOMER", "SHIP_TO_CUSTOMER", "BILL_TO_CUSTOMER", > "PLACING_CUSTOMER"}; > final String[] USER_ORDER_ROLE_TYPES = {"PLACING_CUSTOMER"}; > > for (int i = 0; i < USER_ORDER_ROLE_TYPES.length; i++) { > List<GenericValue> orderRoles = > delegator.findByAnd("OrderRole", UtilMisc.toMap("partyId", > userLogin.get("partyId"), "roleTypeId", USER_ORDER_ROLE_TYPES[i]), null); > -- > Erwan de FERRIERES > www.nereide.biz
