[
https://issues.apache.org/jira/browse/OFBIZ-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252534#comment-13252534
]
Francis ANDRE commented on OFBIZ-4793:
--------------------------------------
Jacques
IMHO, it is likely to leads to some obscur troubles to add those lines
String adminPortStr = getProp(props, "ofbiz.admin.port", "0");
adminKey = getProp(props, "ofbiz.admin.key", "NA");
String adminPortStr = getProp(props, "ofbiz.admin.port", "10523");
adminKey = getProp(props, "ofbiz.admin.key", "so3du5kasd5dn");
because it put the value of the admin port and key in the code instead in
letting it only as a configuration property. If oneday someone comments out the
admin port/key in the start.properties, he won't understand where are coming
those values since there are in the code.
Francis
> unify admin port and key setting: single point of definition in
> start.properties
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-4793
> URL: https://issues.apache.org/jira/browse/OFBIZ-4793
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: WXP SP3 Sun SDK 1.6.0_30
> Reporter: Francis ANDRE
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-admin-port.patch
>
>
> Hi
> If someone wants to change the admin password or port, he would have to
> change currently many files (-- build.xml, various .bat and .sh --). In order
> to avoid this error-prone pratice, I suggest to centralize the definition of
> the admin kay and port at 2 single points: the
> framework/start/src/org/ofbiz/base/start/start.properties and the
> framework/start/src/org/ofbiz/base/start/jetty.properties
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
