[ 
https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255663#comment-13255663
 ] 

Wai commented on OFBIZ-4813:
----------------------------

Regarding point#4(centering of dialog):

I centered it as it looked unusual.  Usually dialogs are at the center of the 
screen.  The modification was for esthetical reasons.  I was not aware it was 
like that by design given your explanation.  I can change it back.

Regarding the change to label CommonSessionTimeoutPleaseLogIn:

The modification was made for the situation where a user has spent time filling 
up a form and them through using the autocompleter realizes that a session 
timeout has occurred.  This normally would cause a mild panic.  Hence the 
message "Your session has expired.  A login is required.  You can refresh the 
page or save your data to login.", lets the user know that there are 2 ways to 
refresh the session. 1) refresh the page. Hence lose all changes. 2) save as 
usually and expect to encounter a login screen during the process.

Regarding removal of code ""requestUrl = getViewNameWithSeparator(requestUrl) + 
...:

The original code uses jQuery(...).load(...) to initiate an ajax request.  The 
new code uses jQuery.ajax(...).  Hence, the code in question became unnecessary 
as jQuery.ajax() requires specification of path and querystring separately.

Regarding the hardcoded timeout:

I should have defined a global variable to specify the value.  I can corrected 
it once all the points have been addressed.

Wai
                
> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
>                 Key: OFBIZ-4813
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4813
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Wai
>         Attachments: ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session 
> timeout.  This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large 
> frame containing a message indicating session has timeout.  Should show a 
> more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box 
> results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window 
> to popup.
> 3. A large round spinner is shown when the ajax dialog is loading.  This 
> spinner image comes from http://mentalized.net/activity-indicators/ and is 
> royalty free.  Note the round spinner does not show in Tomahawk theme as it 
> uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to