[
https://issues.apache.org/jira/browse/OFBIZ-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258804#comment-13258804
]
Jacques Le Roux commented on OFBIZ-1866:
----------------------------------------
I checked, this is still totally wrong and I guess will never be fixed. There
is a promotions intrication case hard to clear up. Actually when you remove one
of the item group then the order does not make sense anymore.
I tried to remove either the 3 "WG-5569 - Tiny Chrome Widget" or the "GZ-2644 -
Round Gizmo" same wrong result
But it seems that we can live with it, nobody never complains about it. I let
open though...
I think in such case uses recreate an order rather than trying to fix this
problem...
Now I wonder if Rashko's patch is not good for other cases which make more
sense. Unfortunately it does not apply anymore
> Problems in order items cancellation and update
> -----------------------------------------------
>
> Key: OFBIZ-1866
> URL: https://issues.apache.org/jira/browse/OFBIZ-1866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Rashko Rejmer
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: order_update_&_cancellation.patch
>
>
> Some problems that occur in order item cancellation and update:
> 1. Wrong amount of promo order header adjustment is calculated when
> cancelling order item.
> How to reproduce: Add 2 item to cart that have promo adjustments, cancel one
> of the items, you will get promo header adjustment with the amount of all
> items promo adjustments.
> 2. If part of an order item is cancelled then cancelled quantity is not
> excluded during recalculation of tax and promotions.
> How to reproduce: create an order with one item for example GZ-1000 x 10,
> then split quantities between 2 ship groups - ship group 00001 = 5 and 00002
> = 5, use DemoCustCompany as a buyer, use CA, USA for ship address for both
> ship groups. Then cancel one of the ship gorups. After that update the
> order(you can simply push "update items" button without any specific
> changes). Tax and promotional adjustments are not recalculated properly when
> updating the order.
> 3. Order grand total, order sub total and order tax total are not displayed
> properly in view order screen. These values include also canceled item
> adjustment amounts.
> How to reproduce: Create an order with DemoCustCompany buyer that contains 2
> order items. E.g. GZ-1000 x 5 and GZ-1001 x 5. Use CA, USA for ship address.
> Then cancel one of the order items. OrderHeader.grandTotal and
> OrderHeader.remainingSubTotal fields will have different amounts from that
> displayed on the view order screen.
> 4. Order item cancellation creates strange balancing order header adjustments
> that reduce the amount of the cancelled order item adjustments. These
> adjustments are deleted after subsequent updates of the order.
> 5. The problem regarding update of an order that have partial invoiced order
> items is still present.
> You can try this by creating order with 2 order items and 2 different ship
> groups. Then ship items from one of the ship groups. Then try to edit the
> price or quantity of the other(not shipped) item.
> This is happening because update of order items is connected to creation of
> shopping cart from order. In this process all the promotional, tax and
> shipping adjustments are removed and then recreated again.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
