If that is the case then the JIRA issue should be reopened again, and the comments posted in this thread should be inserted so that it stays on the radar to be fixed correctly.
Regards, Pierre 2012/5/5 Adrian Crum <[email protected]> > This commit does not fix the problem, it only hides the problem. The > correct fix is to get the bsh: evaluation to return the correct result. > > -Adrian > > > On 5/4/2012 10:46 PM, [email protected] wrote: > >> Author: jleroux >> Date: Fri May 4 21:46:25 2012 >> New Revision: 1334201 >> >> URL: >> http://svn.apache.org/viewvc?**rev=1334201&view=rev<http://svn.apache.org/viewvc?rev=1334201&view=rev> >> Log: >> A slightly modified patch from Ankit Jain "Error on View Facility >> Inventory Items Details Page" https://issues.apache.org/** >> jira/browse/OFBIZ-4851 <https://issues.apache.org/jira/browse/OFBIZ-4851> >> >> Error on https://demo-trunk.ofbiz.**apache.org:8443/facility/**control/** >> ViewFacilityInventoryItemsDeta**ils<https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryItemsDetails>Page, >> when you select Report Type - "By Inventory Item" or "By Product" its >> throwing error. >> >> org.ofbiz.widget.screen.**ScreenRenderException: Error rendering screen >> component://common/widget/**CommonScreens.xml#**GlobalDecorator: >> java.lang.**IllegalArgumentException: Return value from use-when >> condition eval was not a Boolean: null [null] on the field inventoryItemId >> of form ListFacilityInventoryItemsDeta**ilsByItem (Return value from >> use-when condition eval was not a Boolean: null [null] on the field >> inventoryItemId of form ListFacilityInventoryItemsDeta**ilsByItem) >> >> jleroux: I supposed it was related to recent changes on scripts language, >> but was not sure. So I searched for ${bsh:* type="Boolean"/> and found >> some others of the same kind: in UpdateProductFacilityLocations**, >> FindProject, sprintBacklogListItems forms and more in scrumForms.xml. I >> tried with UpdateProductFacilityLocations**& FindProject but >> surprisingly did not reproduce the problem. At this stage I gave up... >> >> Sligth changes from Ankit's patch: I simply used real ' instead of" >> and reformatted to make things more legible >> >> >> Modified: >> ofbiz/trunk/applications/**product/widget/facility/** >> FacilityForms.xml >> >> Modified: ofbiz/trunk/applications/**product/widget/facility/** >> FacilityForms.xml >> URL: http://svn.apache.org/viewvc/**ofbiz/trunk/applications/** >> product/widget/facility/**FacilityForms.xml?rev=1334201&** >> r1=1334200&r2=1334201&view=**diff<http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/facility/FacilityForms.xml?rev=1334201&r1=1334200&r2=1334201&view=diff> >> ==============================**==============================** >> ================== >> --- ofbiz/trunk/applications/**product/widget/facility/**FacilityForms.xml >> (original) >> +++ ofbiz/trunk/applications/**product/widget/facility/**FacilityForms.xml >> Fri May 4 21:46:25 2012 >> @@ -229,7 +229,7 @@ under the License. >> </service> >> </actions> >> <row-actions> >> -<set field="showPosition1" value="${bsh:String >> prev=(String)previousItem.get(**"inventoryItemId");**return >> new Boolean(!(prev!=null&&**prev.equals(inventoryItemId)))**;}" >> type="Boolean"/> >> +<set field="showPosition1" value="${groovy: String prev = (String) >> previousItem.get('**inventoryItemId');return new >> Boolean(!(prev!=null&& prev.equals(inventoryItemId)))**;}" >> type="Boolean"/> >> >> </row-actions> >> >> <field name="inventoryItemId" widget-style="buttontext" >> position="1" use-when="showPosition1"> >> @@ -293,7 +293,7 @@ under the License. >> </service> >> </actions> >> <row-actions> >> -<set field="showPosition1" value="${bsh:String >> prev=(String)previousItem.get(**"productId");return new >> Boolean(!(prev!=null&&**prev.equals(productId)));}" >> type="Boolean"/> >> +<set field="showPosition1" value="${groovy:String prev = (String) >> previousItem.get('productId'); return new Boolean(!(prev!=null&& >> prev.equals(productId)));}" type="Boolean"/> >> >> </row-actions> >> >> <field name="productId" position="1" use-when="showPosition1" >> widget-style="buttontext"> >> >> >>
