Nobody is speaking about swallowing, I hope we have not such things in
OFBiz! (though Scott's wait to read the end before thinking I did not
get you and being upset ;o)
No, it's more about stuff like
} catch (BirtException e) {
throw new ViewHandlerException("Birt Error create engine: " +
e.toString(), e);
} catch (IOException e) {
throw new ViewHandlerException("Error in the response writer/output
stream: " + e.toString(), e);
} catch (SQLException e) {
throw new ViewHandlerException("get connection error: " +
e.toString(), e);
} catch (GenericEntityException e) {
throw new ViewHandlerException("generic entity error: " +
e.toString(), e);
} catch (GeneralException e) {
throw new ViewHandlerException("general error: " + e.toString(), e);
} catch (SAXException se) {
String errMsg = "Error SAX rendering " + page + " view handler: " +
se.toString();
Debug.logError(se, errMsg, module);
throw new ViewHandlerException(errMsg, se);
} catch (ParserConfigurationException pe) {
String errMsg = "Error parser rendering " + page + " view handler:
" + pe.toString();
Debug.logError(pe, errMsg, module);
throw new ViewHandlerException(errMsg, pe);
}
} catch (GeneralException ge) {
String errMsg = "Error rendering " + birtContentType + " attachment
for email: " + ge.toString();
Debug.logError(ge, errMsg, module);
return ServiceUtil.returnError(errMsg);
} catch (IOException ie) {
String errMsg = "Error I/O rendering " + birtContentType + "
attachment for email: " + ie.toString();
Debug.logError(ie, errMsg, module);
return ServiceUtil.returnError(errMsg);
} catch (FOPException fe) {
String errMsg = "Error FOP rendering " + birtContentType + "
attachment for email: " + fe.toString();
Debug.logError(fe, errMsg, module);
return ServiceUtil.returnError(errMsg);
} catch (SAXException se) {
String errMsg = "Error SAX rendering " + birtContentType + "
attachment for email: " + se.toString();
Debug.logError(se, errMsg, module);
return ServiceUtil.returnError(errMsg);
} catch (ParserConfigurationException pe) {
String errMsg = "Error parser rendering " + birtContentType + "
attachment for email: " + pe.toString();
Debug.logError(pe, errMsg, module);
return ServiceUtil.returnError(errMsg);
} catch (EngineException ee) {
String errMsg = "Error rendering " + birtContentType + " attachment
for email: " + ee.toString();
Debug.logError(ee, errMsg, module);
return ServiceUtil.returnError(errMsg);
} catch (SQLException se) {
String errMsg = "Error SQL rendering " + birtContentType + "
attachment for email: " + se.toString();
Debug.logError(se, errMsg, module);
return ServiceUtil.returnError(errMsg);
}
I think the
exception.toString()
Debug.logError(exception, errMsg, module);
information is enough. This for 4 reasons:
1. exception.toString(), and exception in Debug.logError give enough
information. No needs to specify things like
"Error I/O rendering "
"Error FOP rendering"
etc.
this will anyway be given by the thrown exception
2. It's more legible
3. It's an antipattern people C/P (like I did) so it spreads
everywhere in code
4. Those kinds of exception are exceptionally thrown. BTW I personaly
believe checked exceptions in Java is not really the best part
of the language. As soons as it has spread in library and at large
code, you have to suffer all those try/catch blocks
So this like below, this can be rewritten
} catch (Exception e) {
String errMsg = "Error rendering " + birtContentType + " attachment
for email: " + e.toString();
Debug.logError(e, errMsg, module);
return ServiceUtil.returnError(errMsg);
}
