On 05/17/2012 01:11 AM, Jacopo Cappellato wrote: > Adam, all, > > this is interesting, thanks for the research. > > I would suggest the following approach: > > 1) identify which one of the recent changes we did caused this error to happen
I know *exactly* which commit(s) it was. The findByAnd changes I did, the huge commits. > 2) if possible, commit a temporary workaround for this to let the system work > as before The temporary workaround is to s/null/[]/ in all ftl files. That's a very large commit, that will just have to be reverted again when it is fixed properly by freemarker. > 3) file a bug in the Freemarker issue tracker not yet, waiting, see below > 4) contact the Freemarker community to discuss the issue and try to schedule > with them a new release date for the new release (2.3.20); ideally this will > also contain my fixes for the deadlock condition affecting Freemarker not yet, waiting, see below > 5) when the new Freemarker release will be issued, we upgrade OFBiz to it and > we revert #2 I've already got the 2.4 branch git cloned, and have verified the bug still exists. But I need to clone 2.3.19, and work there. When I find these kinds of bugs, I don't file the issue until I have a *very* good handle on it, and in many cases, depending on the severity of the problem, and how easy a workaround might be, I'll even send a patch fixing the problem. I probably would have had a fix yesterday, but we had a client in-house and I had to make some progress for her, while she was here, in case I had any questions. > I can help with #4 as I recently have been in touch with them. > Did you get a chance to figure out how many screens could are affected? If > there are just a few then, instead of #2,we could commit a temporaray fix for > the screens rather than a global one. Every single ftl file I touched that has a null parameter. In fact, this bug *could* affect any method call by freemarker, we've just been lucky.
