Jacques Le Roux wrote:
Adam Heath wrote:
On 06/02/2012 01:06 PM, Jacopo Cappellato wrote:
On Jun 2, 2012, at 7:15 PM, Adam Heath wrote:
There is no way that we can ever enforce a single, unified width. Screen sizes
change, font sizes change. It's too political
to come up with a solution. So, the only fallback is to never split. Then it
is up to each end-developer to modify their
display to handle the long lines.
I would instead prefer the following guideline: "There is no upper limit to
line width; only split long lines if it increases
readability of the code".
That's fine too. I do the same, when embedding a toMap-type call in the
middle of a method invocation, and I forsee the need to add/remove
fields in the future.
In the commit you commented on, I believe I only combined lines that
seemed to be arbitrarily split on individual method arguments, due to
some random screen width. It never really seemed at all consistent.
You could still have cut them at the right place ;o)
I also don't really see the need to go thru and force-reformat
everything. Just do it as we run into stuff. However, I would prefer
it if such reformatting changes were committed separately, and not mixed
in with other real stuff.
Yes I also think it's a bad practise to reformat all: more useless reviews.
Only when we rewrite/refactor makes sense or when it's
really bad (seems that it was your case)
OK, let the creativity flows then...
This said Ctrl+I in Eclipse is still your friend. It's not just about max line
length, but OK we already follow the Sun convention
mostly
I meant Ctrl+Shift+F (default formatter key), since Ctrl+I is only about
indentation.
Jacques
Chapter closed for me
Jacques
