[
https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408868#comment-13408868
]
Jacques Le Roux commented on OFBIZ-4955:
----------------------------------------
Mohamed,
2nd incomplete review and not tested yet, almost ready, few simple issues
* PosTransaction.java: you saved with tabs instead of 4 spaces. Journal.java is
OK so maybe not your EDI (Eclipse?) configiguration. In case (re-)read [General
Formatting
Conventions|https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions]
* JournalLineParams.java misses a license header
* Trivial: you missed to check the ASL granted license when attaching your
patch. PLease (re-)read [How to create a Jira
issue|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices]
{quote}
Don't forget to grant the license to Apache. If not, your patch can't be
included in OFBiz. There is a radio button to select when you're choosing your
patch (Grant license to ASF for inclusion in ASF works (as per the Apache
License ยง5)). Then a small feather will appear next to your patch.
{quote}
> Add rtl layouts to the pos application
> --------------------------------------
>
> Key: OFBIZ-4955
> URL: https://issues.apache.org/jira/browse/OFBIZ-4955
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Mohamed Amine AZZI
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the
> Journal table.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
