[ 
https://issues.apache.org/jira/browse/OFBIZ-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503536#comment-13503536
 ] 

Tom Burns commented on OFBIZ-5070:
----------------------------------

Some of the problem with BIRT really are problems with BIRT see:
http://www.eclipse.org/forums/index.php/m/369012/?srch=setDisplayValue+problem#msg_369015

Many of the BIRT accounting reports use BIRT setDisplayValue in "if" 
statements. 
The effects are very inconsistent. One report renders correctly, others render 
incorrectly or blank. 
Testing is made more difficult by having the accounting component mounted twice 
- in Accounting and in BIRT. 
There are some BIRT reports that have been replaced in accounting with FOP 
reports. 
The FOP reports render data but this is masked by the BIRT mounting which 
redirects the request to a BIRT report that does not work.

Here are some test notes.

BIRT Reports with setDisplayValue:
1. AcctgTransEntriesSearchResultsInvoiceAndPayment.rptdesign
Has screenfop replacement? No
Launch From: 
https://localhost:8443/accounting/control/FindAcctgTransEntries?organizationPartyId=Company
 
Click find
Click Export with Invoice and Payment as PDF opens blank screen
Request: 
/accounting/control/AcctgTransEntriesSearchResultsInvoiceAndPaymentPdf.pdf
Note: request is not in accounting is only in BIRT accounting webapp 
If BIRT disabled will return request not found
If BIRT enabled opens a blank screen

2. BalanceSheet.rptdesign
Has screenfop replacement? Yes
Screenfop renders report? Only if BIRT components disabled.
Launch From: 
https://localhost:8443/accounting/control/BalanceSheet?organizationPartyId=Company
Request: /accounting/control/BalanceSheet.pdf
Note: If BIRT enabled a blank screen is rendered

3. IncomeStatement.rptdesign
Has screenfop replacement? Yes
Screenfop renders report? Only if BIRT components disabled.
Launch From: 
https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company
Request: /accounting/control/IncomeStatementListPdf.pdf
Note: If BIRT enabled a blank screen is rendered

4. InvoiceAcctgTransEntry.rptdesign
Has screenfop replacement? No
Launch From: 
https://localhost:8443/accounting/control/invoiceOverview?invoiceId=8008
Request: /accounting/control/InvoiceAcctgTransEntriesPdf
Note: Report runs but information is not accurate. Debits and Credits are not 
distributed correctly. See PDF Reports 8008 8009

5. PaymentAcctgTransEntry.rptdesign
Has screenfop replacement? No
Launch From: 
https://localhost:8443/accounting/control/paymentOverview?paymentId=8004
Request: /accounting/control/PaymentAcctgTransEntriesPdf
Note: This is the only report that appears to work with setDisplayValue 

6. TrialBalance.rptdesign
Has screenfop replacement? Yes
Screenfop renders report? Only if BIRT components disabled. 
Launch From: 
https://localhost:8443/accounting/control/TrialBalance?organizationPartyId=Company
 Click Submit
Request: /accounting/control/TrialBalanceSearchResultsPdf.pdf

In addition there are the BIRT reports for facility and order manager which do 
not seem to be accessible in the trunk.

If all of the above are correct then the options are:
1. Fix the broken BIRT reports and remove or comment out BIRT request to 
reports that are supported by FOP. Replace BIRT reports not supported by FOP 
with FOP reports. Send BIRT to attic or extras
2. Remove or comment out the BIRT webapp mountings and remove or comment out 
the launch points in trunk to broken reports. Remove broken BIRT reports that 
can not be fixed and send BIRT to attic or extras.
3. Revert to the previous version of the BIRT lib, the last version were 
everything worked. Test BIRT reports, replace BIRT reports not supported by FOP 
with FOP reports. Send BIRT to attic or extras.
4. Something else TBD

Correct me if I am wrong but the only BIRT report that appears to be working 
correctly is PaymentAcctgTransEntry.rptdesign.

If BIRT is to be removed from the trunk, then I think 3 is the best approach. 
Go back to the last known good and dump.

Tom
                
> Problems With BIRT Reports
> --------------------------
>
>                 Key: OFBIZ-5070
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5070
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Tom Burns
>            Assignee: Jacopo Cappellato
>
> Following are results of testing BIRT across four revisions in an effort to 
> identity where BIRT reports work and where they do not.
> Four critical revisions were identified:
> 1. r1003469 introduced BIRT reports in accounting which no longer work.
> 2. r1293999 upgraded the BIRT version after which some reports no longer 
> worked
> 3. r1361130 moved BIRT from framework to specialpurpose breaking other reports
> 4. r1407740 is the current release for compairson
> In the current release the BIRT ofbiz-component.xml was altered to mount BIRT 
> reports and the BIRT Examples (which are no longer in the Example ment) were 
> invoked manually (https://localhost:8443/birt/control/main).
> Test results follow:
> Revision      BIRT Report Name        WIDGET  Test Result     Comment
> r1003469      11/01/2010 Hans Bakker added accounting reports                 
>       AcctgTransEntriesSearchResultsInvoiceAndPayment.rptdesign       
> ReportFinancialSummaryScreens.xml       Pass    
>       PaymentAcctgTransEntry.rptdesign        AccountingMenus.xml     Pass    
>       BalanceSheet.rptdesign  ReportFinancialSummaryScreens.xml       Pass    
>       HTML example.rptdesign  ExampleMenus.xml        Pass    
>       PDF example.rptdesign   ExampleMenus.xml        Pass    
>       HTML chart.rptdesign    ExampleMenus.xml        Pass    
>       PDF chart.rptdesign     ExampleMenus.xml        Pass    
>                               
> r1293999      2/26/2012 Hans Bakker upgrade BIRT to 3.7.2                     
>       AcctgTransEntriesSearchResultsInvoiceAndPayment.rptdesign       
> ReportFinancialSummaryScreens.xml       Fail    Page Blank
>       PaymentAcctgTransEntry.rptdesign        AccountingMenus.xml     Pass    
>       BalanceSheet.rptdesign  ReportFinancialSummaryScreens.xml       Fail    
> Page Blank
>       HTML example.rptdesign  ExampleMenus.xml        Pass    
>       PDF example.rptdesign   ExampleMenus.xml        Pass    
>       HTML chart.rptdesign    ExampleMenus.xml        Pass    
>       PDF chart.rptdesign     ExampleMenus.xml        Pass    
>                               
> r1361130      7/13/2012 jacopoc Moved the "birt" component from framework to 
> specialpurpose                   
>       AcctgTransEntriesSearchResultsInvoiceAndPayment.rptdesign       
> ReportFinancialSummaryScreens.xml       Fail    Page Blank
>       PaymentAcctgTransEntry.rptdesign        AccountingMenus.xml     Fail    
> Form opens without data
>       BalanceSheet.rptdesign  ReportFinancialSummaryScreens.xml       Fail    
> Page Blank
>       HTML example.rptdesign  ExampleMenus.xml        Fail    Table (id = 10):
> + A BIRT exception occurred. See next exception for more information.
> Invalid javascript expression: dataSetRow["exampleId"] (Element ID:10)
>       PDF example.rptdesign   ExampleMenus.xml        Fail    Form opens 
> without data
>       HTML chart.rptdesign    ExampleMenus.xml                
> Table (id = 32):
> + A BIRT exception occurred. See next exception for more information.
> Invalid javascript expression: dataSetRow["exampleTypeId"] (Element ID:32)
> Chart (id = 49):
> + A BIRT exception occurred. See next exception for more information.
> Invalid javascript expression: dataSetRow["exampleTypeId"] (Element ID:49)
> Chart (id = 50):
> + A BIRT exception occurred. See next exception for more information.
> Invalid javascript expression: dataSetRow["exampleTypeId"] (Element ID:50)
>       PDF chart.rptdesign     ExampleMenus.xml        Fail    Form opens 
> without data
>                               
> r1407740      Trunk As Of 11/10/2012                  
>       AcctgTransEntriesSearchResultsInvoiceAndPayment.rptdesign       
> ReportFinancialSummaryScreens.xml       Fail    Page Blank
>       PaymentAcctgTransEntry.rptdesign        AccountingMenus.xml     Fail    
> Form opens without data
>       BalanceSheet.rptdesign  ReportFinancialSummaryScreens.xml       Fail    
> Page Blank
>       HTML example.rptdesign  ExampleMenus.xml        Fail    Table (id = 10):
> + A BIRT exception occurred. See next exception for more information.
> Invalid javascript expression: dataSetRow["exampleId"] (Element ID:10)
>       PDF example.rptdesign   ExampleMenus.xml        Fail    Form opens 
> without data
>       HTML chart.rptdesign    ExampleMenus.xml                
> Table (id = 32):
> + A BIRT exception occurred. See next exception for more information.
> Invalid javascript expression: dataSetRow["exampleTypeId"] (Element ID:32)
> Chart (id = 49):
> + A BIRT exception occurred. See next exception for more information.
> Invalid javascript expression: dataSetRow["exampleTypeId"] (Element ID:49)
> Chart (id = 50):
> + A BIRT exception occurred. See next exception for more information.
> Invalid javascript expression: dataSetRow["exampleTypeId"] (Element ID:50)
>       PDF chart.rptdesign     ExampleMenus.xml        Fail    Form opens 
> without data
>                               

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to